Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded project id #4

Open
Jonas-Sander opened this issue Jan 10, 2021 · 0 comments
Open

Hard coded project id #4

Jonas-Sander opened this issue Jan 10, 2021 · 0 comments

Comments

@Jonas-Sander
Copy link
Contributor

Under https://www.github.com/SharezoneApp/cloud_firestore_server/tree/main/cloud_firestore_server%2Flib%2Fsrc%2Finternal%2Ffirestore_run_query_fixed_extension.dart the project id "sharezone-debug" is still hard coded.

Jonas-Sander added a commit that referenced this issue Jan 10, 2021
Added support for inner/base http client in Firestore constructors.

You can now pass `Firestore` an `package:http` `Client` which can be used to add logging or request modification.  

For example:   
```dart
final firestore = Firestore.newInstance(
  credentials: myCredentials,
  innerClient: LoggingHttpClient(),
);

class LoggingHttpClient extends http.BaseClient {
  final http.Client _delegate = http.Client();

  @OverRide
  Future<http.StreamedResponse> send(http.BaseRequest request) {
    print('Sending request: $request');
    return _delegate.send(request);
  }
}
```

Additionally I added a `run-remote-tests` workflow that runs all tests that call the remote Firestore server.  
Another workflow running the other tests using the emulator needs to be added as well in the future.

This is also a prerequisite to be able to make a regression test for #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant