-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decreasing Module Size in Maps Degrades Performance Significantly #370
Comments
please add links to full plots for both cases (not just CSV and comparisons) |
now I'm curious if we can go lower in size below the "hit-based" without a loss of efficiency and increase in fakes yet (subtract, e.g. a half of the difference) |
If I do half of the extensions, so half way between the hit-based and CSV sizes, I don't see a fakerate jump. Number of Connections, Straight: 67,980 reduced to 64,886 Ignore the labels below, it should say, "In-between" sizes or something like that for the green. Keep in mind the plots below are in comparison to Master. In-Between Sizes: Here |
interesting how about 1/4? |
I just want to point out too that this isn't an issue in my code. If you change the current hit-based code from Phillip to use the slightly smaller csv sizes then you get the performance plots below @slava77 @VourMa Hit-Based Geometry with CSV Module Sizes: Here Comparison to Master below, showing the fakerate of pt3's going up. |
We found some hardcoded places in the LST code package that the module sizes are hardcoded. Some examples are in the links below. This indicates that if we change the module size in the module map, we need to also change those consistently. More places need to be checked. Lines 160 to 161 in 78d8d24
Lines 1185 to 1187 in 78d8d24
TrackLooper/SDL/PixelTriplet.h Lines 830 to 836 in 78d8d24
Line 362 in 78d8d24
|
Just want to add for @YonsiG's comment that the 0.15 number is the pixel size for the PS module, not the module size. |
See SegmentLinking/LSTGeometry#9 for more information and the plots below. In the module maps the sensors are assumed to be (100, 100) mm or (100, 50) mm (width, length) but the geometry CSV files from tklayout specify them as (91.4, 100.5) mm and (96.0, 46.9) mm, slightly smaller. Using these sizes in the module map assumptions leads to the fake rate spiking and efficiency decreasing.
The text was updated successfully, but these errors were encountered: