-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WARemoteDebuggingWalkback broken starting in GemStone 3.7.0 #1355
Comments
Looks like JQJsonFunctionalTest>>seasidePackagesOn: sends #array: that is not implemented in GemStone ... did not show up as a test failure during internal battery tests runs and I found it while characterizing #_continue issue |
ignore the read 'x' ... test for b3831fb have passed |
@dalehenrich I guess this issue can now be closed again? |
Or actually... the issue with the |
WARemoteDebuggingWalkback>>resumeContinuation sends the message #_continue to GsProcess instance after #resumeContinuation is sent and conditionally sends second #_continue message ...
In 3.7.0 we updated the GsProcess implementation to improve it's muti-threaded behavior and in the process the GsProcess>>_continue method was removed ...
I'm not sure how much WARemoteDebuggingWalkback is used in the wild, but at a minimum we shouldn't fail the Seaside tests because of this "sent but not implemented" message ...
In 3.7.0 we have also done significant work in using topaz for remote debugging with the DEBUGGEM topaz command and I would be inclined to replace the WARemoteDebuggingWalkback functionality with support for DEBUGGEM ...
In a nutshell by using
System waitForDebug
a process id and unique token are written to the gem's log file and the process is suspended until a topaz session running on the same machine attaches to the process ... once attached you can debug the process using a topaz debugger and subsequently continue execution, kill the gem, or detach and leave process suspended ...The text was updated successfully, but these errors were encountered: