Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARemoteDebuggingWalkback broken starting in GemStone 3.7.0 #1355

Open
dalehenrich opened this issue Feb 23, 2023 · 4 comments
Open

WARemoteDebuggingWalkback broken starting in GemStone 3.7.0 #1355

dalehenrich opened this issue Feb 23, 2023 · 4 comments
Assignees

Comments

@dalehenrich
Copy link
Member

WARemoteDebuggingWalkback>>resumeContinuation sends the message #_continue to GsProcess instance after #resumeContinuation is sent and conditionally sends second #_continue message ...

In 3.7.0 we updated the GsProcess implementation to improve it's muti-threaded behavior and in the process the GsProcess>>_continue method was removed ...

I'm not sure how much WARemoteDebuggingWalkback is used in the wild, but at a minimum we shouldn't fail the Seaside tests because of this "sent but not implemented" message ...

In 3.7.0 we have also done significant work in using topaz for remote debugging with the DEBUGGEM topaz command and I would be inclined to replace the WARemoteDebuggingWalkback functionality with support for DEBUGGEM ...

In a nutshell by using System waitForDebug a process id and unique token are written to the gem's log file and the process is suspended until a topaz session running on the same machine attaches to the process ... once attached you can debug the process using a topaz debugger and subsequently continue execution, kill the gem, or detach and leave process suspended ...

@dalehenrich dalehenrich self-assigned this Feb 23, 2023
@dalehenrich
Copy link
Member Author

Looks like JQJsonFunctionalTest>>seasidePackagesOn: sends #array: that is not implemented in GemStone ... did not show up as a test failure during internal battery tests runs and I found it while characterizing #_continue issue

@dalehenrich
Copy link
Member Author

ignore the read 'x' ... test for b3831fb have passed

@dalehenrich dalehenrich reopened this Feb 27, 2023
dalehenrich added a commit to GsDevKit/GsDevKit_home that referenced this issue Feb 28, 2023
@jbrichau
Copy link
Member

jbrichau commented Sep 1, 2023

@dalehenrich I guess this issue can now be closed again?

@jbrichau
Copy link
Member

jbrichau commented Sep 2, 2023

Or actually... the issue with the WARemoteDebuggingWalkback not working anymore starting GS 3.7 should be handled. Ok, leave this one open and I will create a separate issue for it before closing this one.

@jbrichau jbrichau changed the title Port to GemStone 3.7.0 WARemoteDebuggingWalkback broken starting in GemStone 3.7.0 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants