Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing some core Speasy methods to users #96

Open
jeandet opened this issue Sep 20, 2023 · 4 comments
Open

Exposing some core Speasy methods to users #96

jeandet opened this issue Sep 20, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@jeandet
Copy link
Member

jeandet commented Sep 20, 2023

I'm thinking about exposing some Speasy core methods as user API since they might be handy for users.
We could expose and document as public API the following methods:

The main drawback to this is that we lose the ability to change the behavior or remove those functions.

@jeandet jeandet self-assigned this Sep 20, 2023
@jeandet jeandet added enhancement New feature or request question Further information is requested labels Sep 20, 2023
@jeandet
Copy link
Member Author

jeandet commented Sep 20, 2023

@brenard-irap, @KatraB in case you have any opinion on this.
@jgieseler maybe you could have any use of such functions?

@KatraB
Copy link

KatraB commented Sep 21, 2023

@brenard-irap, @KatraB in case you have any opinion on this. @jgieseler maybe you could have any use of such functions?

Well, i think it makes sense to expose those functions, many of them (list_files, datetime, ...) are not very risky or subject to change so why not. In the worst case, if some changes were needed, it could be considered to use functions overload to implement changes without breaking anything, no?

@jgieseler
Copy link
Contributor

I'm not sure if it's worth the effort if you're not yourself benefiting from it (like loading them from here somewhere else). The functions are quite specific. I guess most users will write them themselves and/or won't find them from here...

@jeandet
Copy link
Member Author

jeandet commented Sep 22, 2023

@jgieseler that's the question, I mostly agree with you on epoch/utc functions but not so sure with the other ones.
At least we have students and physicists in our lab who might use those functions once they are able to find them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants