Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSliced and SLSliced Broadcasting #57

Open
ChrisRackauckas opened this issue Apr 30, 2019 · 2 comments
Open

LSliced and SLSliced Broadcasting #57

ChrisRackauckas opened this issue Apr 30, 2019 · 2 comments

Comments

@ChrisRackauckas
Copy link
Member

These were relying on the LArray broadcasts, but these now fail because of the proper index handling that was required for things like x .* x' to work. Instead, these need their own broadcast overloads so that way they can produce the correct output types, and then it should all automatically work.

@ChrisRackauckas
Copy link
Member Author

@rafaqz does the multidimensional forms of #61 work for LSliced and SLSliced use cases you had? I think we might want to narrow it down to this type, and maybe give it an alternative macro for versions that are views to rows, but I think this structure might be much simpler to maintain and work with.

@rafaqz
Copy link
Contributor

rafaqz commented May 8, 2019

have to apologise here, I'm a few weeks out from handing in my thesis I might not be able to look at this for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants