Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FOF files #156

Open
MatthieuSchaller opened this issue Jan 18, 2023 · 9 comments
Open

Support for FOF files #156

MatthieuSchaller opened this issue Jan 18, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@MatthieuSchaller
Copy link
Member

We could probably add support for the FOF files rather easily. They have the same format as the snapshots but don't have /PartType?. They instead have Groups. The arrays within there have the same unit meta-data and description as the particle-carried fields.
Only other difference is that the arrays have size /Header/NumGroups_Total.

@MatthieuSchaller MatthieuSchaller added the enhancement New feature or request label Jan 18, 2023
@JBorrow
Copy link
Member

JBorrow commented Sep 7, 2023

This is a good first issue if you have any new grad students joining this year :)

@MatthieuSchaller
Copy link
Member Author

@robjmcgibbon might also be interested as a first side thing to understand the internal structure of swiftsimio.

@JBorrow
Copy link
Member

JBorrow commented Sep 7, 2023

Sounds good. If Rob is interested, I am happy to help.

@robjmcgibbon
Copy link
Collaborator

Yep I think this would be good to work on to gain some understanding of the repo. Do you think it's worth having a call about how to go about it or should I just get stuck in and look myself?

@JBorrow
Copy link
Member

JBorrow commented Sep 8, 2023

Excellent! Feel free to take a look yourself first, it should be somewhat well documented. If it's not, then that's something we should address!

Ideally, the load function would figure out if you are trying to load a snapshot or a FoF output automatically.

All the code you commit to the repo will be reviewed in a similar manner to SWIFT itself. Let me know if you have any issues, and we can schedule a call, but feel free to get stuck in!

@JBorrow
Copy link
Member

JBorrow commented Oct 6, 2023

@robjmcgibbon Have you had a chance to look at this? Let me know if you're stuck!

Given how big the volumes are getting, it would be nice to have this work with partial spatial loading too...

@robjmcgibbon
Copy link
Collaborator

Hi Josh, nope haven't looked yet, been working on SOAP stuff. Hopefully will get to it next week when cosma is busy.

@MatthieuSchaller
Copy link
Member Author

Note that I am looking at adding a meta "snapshot" too for the FOF catalogs on the SWIFT side. Might help here too.

@MatthieuSchaller
Copy link
Member Author

FYI, there is now a meta-snapshot also for the FOF output. So only need to read one file even when running over MPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants