-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for FOF files #156
Comments
This is a good first issue if you have any new grad students joining this year :) |
@robjmcgibbon might also be interested as a first side thing to understand the internal structure of swiftsimio. |
Sounds good. If Rob is interested, I am happy to help. |
Yep I think this would be good to work on to gain some understanding of the repo. Do you think it's worth having a call about how to go about it or should I just get stuck in and look myself? |
Excellent! Feel free to take a look yourself first, it should be somewhat well documented. If it's not, then that's something we should address! Ideally, the All the code you commit to the repo will be reviewed in a similar manner to SWIFT itself. Let me know if you have any issues, and we can schedule a call, but feel free to get stuck in! |
@robjmcgibbon Have you had a chance to look at this? Let me know if you're stuck! Given how big the volumes are getting, it would be nice to have this work with partial spatial loading too... |
Hi Josh, nope haven't looked yet, been working on SOAP stuff. Hopefully will get to it next week when cosma is busy. |
Note that I am looking at adding a meta "snapshot" too for the FOF catalogs on the SWIFT side. Might help here too. |
FYI, there is now a meta-snapshot also for the FOF output. So only need to read one file even when running over MPI. |
We could probably add support for the FOF files rather easily. They have the same format as the snapshots but don't have
/PartType?
. They instead haveGroups
. The arrays within there have the same unit meta-data and description as the particle-carried fields.Only other difference is that the arrays have size
/Header/NumGroups_Total
.The text was updated successfully, but these errors were encountered: