Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THUB-21 | @jdwjdwjdw | Person node and teaser adjustments #8

Merged
merged 7 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/css/main.css

Large diffs are not rendered by default.

21 changes: 18 additions & 3 deletions src/scss/components/hero-banner/_hero-banner.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,17 +53,32 @@
}
}

// Alert that appears after adding / editing a page
main .su-alert {
margin-top: 2rem;
z-index: 12;
position: absolute;
width: 30%;

@include grid-media-min('lg') {
margin-top: -3rem;
width: 100%;
}

// Alert that appears after adding / editing a page
&.su-alert--info {
margin-top: 2rem;

@include grid-media-min('lg') {
margin-top: -3rem;
}
}

// Alert that appears for unpublished pages
&.su-alert--warning {
margin-top: 17rem;

@include grid-media-min('lg') {
margin-top: 7rem;
}
}

.su-alert__dismiss {
margin-left: 0;
Expand Down
1 change: 1 addition & 0 deletions src/scss/components/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@
@import 'local-footer/index';
@import 'main-nav/index';
@import 'masthead/index';
@import 'person/index';
@import 'search/index';
@import 'teaser/index';
29 changes: 29 additions & 0 deletions src/scss/components/person/_person-node.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
@charset "UTF-8";

.content {
.layout--section-person-header .su-quote__media.flex-2-of-12 .field-media-image {
border-radius: unset;
}

.su-person-content {
.main-region {
.block__title {
@include thub-heading--badge;
@include type-c;
}

.node-stanford-person-su-person-affiliations {
a {
@include thub-button--gradient;
}
}
}
}
}

// .node-stanford-person-su-person-education h2.block__title,
// .node-stanford-person-su-person-research h2,
// .node-stanford-person-su-person-affiliations h2 {
// @include thub-heading--badge;
// @include type-c;
// }
47 changes: 47 additions & 0 deletions src/scss/components/person/_person-teasers.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
@charset "UTF-8";

.ptype-stanford-entity,
.paragraph--type--stanford-entity {

.ds-entity--stanford-person {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenbreese should the Person Teaser span full width for single column/responsive? 🤔

For the screenshot, my screen width was 640px
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebeccahongsf No, Kerri wanted the person teaser only to have the max width of 400. I forgot to put in the jira ticket to the PR. I'm sorry about that. https://stanfordits.atlassian.net/browse/THUB-21

max-width: 400px;

.su-card {
border: none;
box-shadow: none;

.su-person-photo {
padding: 0 0 0 7rem;
}

.su-person-photo img,
.su-person-photo picture {
border-radius: 0;
}

section.su-card__contents {
padding: 2rem 3rem 3.2rem 3.2rem;
text-align: left;

h2,
h3 {
a {
@include thub-type-d;

background: $thub-gradient-lagunita-to-ochre;
-webkit-background-clip: text;
-webkit-text-fill-color: transparent;

&:hover,
&:focus,
&:active {
background: $thub-color-ochre-dark;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underline is missing on hover/focus 👀

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebeccahongsf I see an underline on hover on my person teaser. Can you pull and refresh?
Screenshot 2024-07-09 at 10 34 03 AM

-webkit-background-clip: text;
-webkit-text-fill-color: transparent;
}
}
}
}
}
}
}
6 changes: 6 additions & 0 deletions src/scss/components/person/index.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
@charset "UTF-8";

// Person Roll Up

@import 'person-node';
@import 'person-teasers';
Loading