THUB-21 | @jdwjdwjdw | Person node and teaser adjustments

[jdwjdwjdw]

READY FOR REVIEW

Summary

• THUB-21: People card (or basic card variant for people)
• Person node and teaser adjustments
• Admin fixup for unpublished page alert

Review By (Date)

• When does this need to be reviewed by?

Criticality

• How critical is this PR on a 1-10 scale? Also see Severity Assessment.
• E.g., it affects one site, or every site and product?

Urgency

• How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Rebuild Cache and import config drush cr ; drush ci
3. Create some people. Add a short title with the long content you want to display on the teaser.
4. Verify the cards look like the design. We discussed and know about the short title and the long title being kind of confusing.
5. Add a global message. Verify it works on the admin view.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- THUB-21

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[rebeccahongsf]

@jenbreese should the Person Teaser span full width for single column/responsive? 🤔

For the screenshot, my screen width was 640px

[jenbreese]

@rebeccahongsf No, Kerri wanted the person teaser only to have the max width of 400. I forgot to put in the jira ticket to the PR. I'm sorry about that. https://stanfordits.atlassian.net/browse/THUB-21

[rebeccahongsf]

Underline is missing on hover/focus 👀

[jenbreese]

@rebeccahongsf I see an underline on hover on my person teaser. Can you pull and refresh?

[rebeccahongsf]

Just these fixes and we should be good to go @jenbreese! 😃

[jenbreese]

@rebeccahongsf Can you try this last one? I think it is good to go. Last PR for THUB :)

[rebeccahongsf]

LGTM 🚢