Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Decanter reference #25

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Fix to Decanter reference #25

merged 2 commits into from
Feb 21, 2024

Conversation

jenbreese
Copy link
Collaborator

@jenbreese jenbreese commented Feb 16, 2024

READY FOR REVIEW

Summary

  • fix to Decanter ref

Review By (Date)

  • asap

Criticality

  • high

Urgency

  • high

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to page and verify it loads
  4. Verify accepting the disclaimer works and page loads.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for me, thanks!

@jdwjdwjdw jdwjdwjdw merged commit 505b0f3 into 1.x Feb 21, 2024
1 check passed
@jdwjdwjdw jdwjdwjdw deleted the bondholder--decanter-ref branch February 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants