SDSS-1299: Add Explore More options and display to News #466
Conversation
|
@buttonwillowsix it looks like "Explore More" is showing when there's no results.
|
There was a problem hiding this comment.
@buttonwillowsix This is really neat! I tested everything and only had 1 spot where it wasn't working correctly. I also had a few questions comments.
- Test the random default view. This worked perfectly.
- Test the contextual filter on the Random display. This did not work. It was still completely random. I created 5 articles, 3 with announcement as the News Type and 2 with Blog as the News type. I edited an article and entered "Blog" in the arguments for the Random display and it still was completely random (it showed both Announcement articles and Blog articles).
- Test curated display: "News that is selected as related on this article". This worked, however I had to make sure to clear the arguments. I also think this should be re-labeled. Maybe "Use related content selections"? I find the names confusing.
- Test curated display: "News that has selected this article as related". This also works, but again the labeling could maybe be more clear?
A few other questions/concerns:
- There is inconsistent labeling. One display is prefaced with "Explore More -" while the other two are prefaced with "Explore More News -".
- The arguments field still works for the two Curated displays. Is this intentional?
- The Explore option allows you to set the "View" to "None" but it still displays the "Explore More" header (with nothing underneath it). Is this something we want to prevent?
- If there are no relevant results for the Explore More view, it displays the "Explore More" header with nothing underneath it. What behavior should happen there?
|
These are all great comments! And I like your improved suggest for labeling the curated view. I struggled a ton with how to describe these and was hoping to be struck with inspiration that never came. I will fix this stuff up in the branch (I can make that my next priority today) and then pass it back to you. I will see what I can do about the header. I like the option to have "none" there because there may be cases where that would be appropriate. |
|
Sounds good! I think removing the filtering makes sense for now as an MVP and could be added later. Contextual filters can be time consuming. |
|
The contextual filter on the random display was not set up (which is why it didn't work.) The only filter I have on there is the one to filter out the current piece of news! I will not be making changes there. The same is true on the other two displays. It is working as designed in that respect! |
|
@buttonwillowsix Is this ready for review again? |
There was a problem hiding this comment.
❌ I saw the <h2> is hard-coded into the view in a custom HTML field now to hide it when there's no content. Is there a way to hide the title if the view block is empty using Layout Builder? It'd be nice to not have this <h2> hard-coded in a custom text field in the view header.
❓ The argument is not working for any of the views now. I tested multiple scenarios with different News Type terms, and they are always empty. I assume this is fine for now?
✔️ Updated labels look good.
|
@joegl I will see if Layout Builder will take care of it now that I added some "hide this view if empty" to the settings. I think my problem was that if I show the view header, I don't have a way to style it without adding a template to get an H2 and a class on view header. I don't think we want people changing the title on individual pages, but I agree it is more elegant to use Layout Builder. I will look this AM. There is no contextual filter available for the user to interact with, so that is totally fine. I wish we could hide that field if the only contextual filter is the one that filters out the current node, but I don't think there is. It probably would be easy to add a topical contextual filter on that, though. If you'd like, I could add that in (especially since this seems unlikely to make this release at this point.. hoping we can release it pretty soon, though! |
Sounds great Dena. I'd be happy to get this out today as-is if we can figure out the title issue though that'd be great. |
|
@joegl I think if we want to use the view header, I will need to add a twig template to wrap the view header in an h2 and the block-title class. I haven't done that in ages, and probably would not have time to add that until maybe Friday at the earliest. Let me know if that sounds like a good approach. |
|
@buttonwillowsix It's too bad the viewfield display block doesn't have a way to hide the entire block (including the title) if the view contents are empty. That would seem most straightforward. |
It does have a way to hide the entire block if it is empty (including title,) I just don't have a way to style the title without either a) a FE dev to add the styling in the theme (I don't think we want this because we also want it to be an H2) or b) adding a template to wrap the title in existing styling. It sounds like you'd prefer that we take the approach of using the view title, so I can do that (again, probably not until Friday. I need a quiet moment to remember even how to turn on the theming suggestions so I can remember how to make the template!) |
|
@buttonwillowsix The block title should already be styled if it's using layout builder shouldn't it? I can definitely look at styles if needed. |
Yes! That is the one that is styled. But the Layout Builder title appears even if the block is blank. So we have to use the view title. Layout builder can use the view title, but that is not styled. If this helps:
|
👍 I misunderstood when you said "It does have a way to hide the entire block if it is empty (including title)". |
|
Make field required. Then put no results text in view. Go back to Layout Builder title. |
joegl
changed the title
READY FOR REVIEW
Summary
Review By (Date)
Criticality
-HIGH
Review Tasks
Setup tasks and/or behavior to test
Test the random default view
Test the contextual filter on the Random display
Test curated displays
Front End Validation
No new front-end code
Backend / Functional Validation
Code
General
Affected Projects or Products
Associated Issues and/or People
- SDSS-1299
Resources