Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDSS-830: Merge newsroom layout paragraphs feature branch #200

Merged
merged 18 commits into from
Aug 2, 2023
Merged

SDSS-830: Merge newsroom layout paragraphs feature branch #200

merged 18 commits into from
Aug 2, 2023

Conversation

joegl
Copy link
Collaborator

@joegl joegl commented Aug 2, 2023

NOT READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

https://stanfordits.atlassian.net/browse/SDSS-830

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to...
  3. Verify...

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

joegl and others added 18 commits June 7, 2023 13:17
@joegl
SDSS-600: Changed News components field to layout_paragraphs (#125)
173aee5 
* SDSS-600: Added and layout_paragraphs module.
* SDSS-600: Switched news node component widget to layout paragraphs.
@joegl
Merge branch '2.x' into feature/newsroom-layout-paragraphs
3027716
@joegl
SDSS-731: Layout paragraphs updates (#155)
305b27c 
* SDSS-731: Switched News components field to layout_paragraphs.
* SDSS-731: Enabled stanford_layout_paragraphs.
* SDSS-731: Updated news display.
@jenbreese
SDSS-731: Added custom sdss_layout_paragraphs module (#163)
b03600c 
* SDSS-731: Added custom sdss_layout_paragraphs module with custom layouts for layout_paragraphs.
@jenbreese
SDSS-778: Set article body width for newsroom only (#177)
eeadfdd 
* SDSS-778: Set article body width for newsroom only.
@jenbreese
SDSS-589: News node top component (#168)
7cddff6 
* SDSS-589: News node top component.
@jenbreese
SDSS-591: Add Newsroom Callout component (#170)
e2d38de 
* SDSS-591: Add Newsroom Callout component .
@jenbreese
SDSS-592: Add sidebar component (#172)
d69e84c 
* SDSS-592: Add sidebar component.
@joegl
Merge branch '2.x' into feature/newsroom-layout-paragraphs
a2b8e55
@jenbreese
SDSS-786: Article page tweaks (#184)
98b6184 
* SDSS-786: Article page tweaks.
@joegl
SDSS-788: Added and configured stage file proxy (#183)
823af82 
* SDSS-788: Added and configured stage file proxy.
@joegl
Merge branch '2.x' into feature/newsroom-layout-paragraphs
c2d5ffd
@jenbreese
SDSS-816: Use serif font for block quote styles, updated decanter. (#194
14548e4 
)

* SDSS-816: Use serif font for block quote styles.
* Updated decanter version in sdss_subtheme.
@jenbreese
SDSS-822: Adjusted spacing for news article top component without byl…
e5a5490 
…ine (#195)

* SDSS-822: Adjusted spacing for news article top component without byline.
@jenbreese
SDSS-613: Adjusted Event and News taxonomy text to accessible colors (#…
84269c7 
…196)

* SDSS-613: Adjusted Event and News taxonomy text to accessible colors.
@jenbreese
SDSS-824: Fixed Firefox wrapping bug with caption text (#197)
bbfa616 
* SDSS-824: Fixed Firefox wrapping bug with caption text.
@jenbreese
SDSS-823: Added bottom margin to News nodes to add space before footer (
305180a 
#199)

* SDSS-823: Added bottom margin to News nodes to add space before footer.
@jenbreese
SDSS-793: Added icons for new Sidebar and Callout paragraph types (#198)
ed94648 
* SDSS-793: Added icons for new Sidebar and Callout paragraph types.
@joegl joegl merged commit 7fe4ea1 into 2.x Aug 2, 2023
@joegl joegl deleted the feature/newsroom-layout-paragraphs branch August 2, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joegl @jenbreese