Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Nested DOE for MFK #650

Open
jtneedels opened this issue Sep 17, 2024 · 1 comment
Open

Question: Nested DOE for MFK #650

jtneedels opened this issue Sep 17, 2024 · 1 comment
Labels

Comments

@jtneedels
Copy link

jtneedels commented Sep 17, 2024

Hi,

I know a requirement of this AR1 MFK implementation is a nested DOE, where higher fidelity data is included in the lower fidelity dataset.

I was checking the MFK function and noticed it will accept non-nested datasets without throwing an error, but of course results in an incorrect procedure. I was curious - what is occurring, in terms of this coded implementation, when non-nested datasets are used? And is there a reason for not having an error when non-nested inputs are detected? I saw in Le Gratiet's thesis he describes a version of the algorithm not requiring nesting, but I need to study it further to understand the differences.

The SMT package is great, I've used it for MFK in my PhD (citing of course!) and I was curious if there are any ways to get more involved with developing/contributing to the code base?

Thank you so much!

@relf
Copy link
Member

relf commented Nov 8, 2024

Hi, sorry for the late reply. No reason to not check nested inputs for MFK only it is not implemented (PR welcomed!). Speaking of contributing you can refer to the documentation on the topic.
Notice in the latest release 2.8, the addition of the new multi-fi MFCK model which does not require nested inputs.

@relf relf added the question label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants