fix(dynamic-page) redundant title hover removed #10092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgogov
reviewed
Oct 31, 2024
PetyaMarkovaBogdanova
force-pushed
the
fix-dynamic-page-title-hover
branch
from
ca7bc15
to
770c545
Compare
kgogov
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to not get redundant hover state, we should "clean" it on every rerender, since sometimes, when pressing the expand/collapse button, the change of the position of the mouse pointer is ignored according to viewport and the "hovered"
attribute remains in the title.
I tried to cover the functionality with a test, but the specific mouse behaviour is hard to be mocked.
Fixes: #10019