diff --git a/.github/workflows/release-rc-auto.yaml b/.github/workflows/release-rc-auto.yaml
index 3f746292d213..9d60c897178f 100644
--- a/.github/workflows/release-rc-auto.yaml
+++ b/.github/workflows/release-rc-auto.yaml
@@ -42,3 +42,15 @@ jobs:
NPM_AUTH_TOKEN: ${{ secrets.NPM_RELEASE_AUTH_TOKEN }}
GH_TOKEN: ${{ secrets.UI5_WEBCOMP_BOT_GH_TOKEN }}
run: yarn lerna publish from-git --yes
+
+ - name: Pre-Deploy
+ run: |
+ yarn ci:deploy:nightly
+
+ - name: Deploy
+ uses: JamesIves/github-pages-deploy-action@v4.3.3
+ with:
+ branch: gh-pages # The branch the action should deploy to.
+ folder: packages/website/build # The folder the action should deploy.
+ target-folder: nightly
+ clean: true
diff --git a/.github/workflows/release-rc.yaml b/.github/workflows/release-rc.yaml
index 85564d7cfe7a..0faaac4ebfb1 100644
--- a/.github/workflows/release-rc.yaml
+++ b/.github/workflows/release-rc.yaml
@@ -42,6 +42,10 @@ jobs:
GH_TOKEN: ${{ secrets.UI5_WEBCOMP_BOT_GH_TOKEN }}
run: yarn lerna publish from-git --yes
+ - name: Pre-Deploy
+ run: |
+ yarn ci:deploy:nightly
+
- name: Deploy
uses: JamesIves/github-pages-deploy-action@v4.3.3
with:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 01b1a6cca5fc..8fe3c15cb340 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,23 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+
+### Bug Fixes
+
+* dev-server correctly imports yargs ([#10048](https://github.com/SAP/ui5-webcomponents/issues/10048)) ([7b5aa5e](https://github.com/SAP/ui5-webcomponents/commit/7b5aa5ebdddbbc0493f4699c1a74db497e22368b))
+* **ui5-dynamic-page:** align header area with title and content ([#10053](https://github.com/SAP/ui5-webcomponents/issues/10053)) ([61e3dbd](https://github.com/SAP/ui5-webcomponents/commit/61e3dbd1f9a5b69c824cfcdae5c750d59585615a))
+
+
+### Features
+
+* **ui5-tabcontainer:** style adjustments for transparent header ([#10064](https://github.com/SAP/ui5-webcomponents/issues/10064)) ([b5e596e](https://github.com/SAP/ui5-webcomponents/commit/b5e596e542a4fbd3f0643b15d2f4023be2079f5a))
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
diff --git a/lerna.json b/lerna.json
index 15e34021f0cf..6d77afe05069 100644
--- a/lerna.json
+++ b/lerna.json
@@ -14,7 +14,7 @@
"packages/create-package",
"packages/compat"
],
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"command": {
"publish": {
"allowBranch": "*",
diff --git a/packages/ai/CHANGELOG.md b/packages/ai/CHANGELOG.md
index f5ff10531e8f..834090a23c9d 100644
--- a/packages/ai/CHANGELOG.md
+++ b/packages/ai/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-ai
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-ai
diff --git a/packages/ai/package.json b/packages/ai/package.json
index 6ad32c223426..e2995fc9f4f0 100644
--- a/packages/ai/package.json
+++ b/packages/ai/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-ai",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.ai",
"ui5": {
"webComponentsPackage": true
@@ -45,13 +45,13 @@
"directory": "packages/ai"
},
"dependencies": {
- "@ui5/webcomponents": "2.4.0-rc.2",
- "@ui5/webcomponents-base": "2.4.0-rc.2",
- "@ui5/webcomponents-icons": "2.4.0-rc.2",
- "@ui5/webcomponents-theming": "2.4.0-rc.2"
+ "@ui5/webcomponents": "2.4.0-rc.3",
+ "@ui5/webcomponents-base": "2.4.0-rc.3",
+ "@ui5/webcomponents-icons": "2.4.0-rc.3",
+ "@ui5/webcomponents-theming": "2.4.0-rc.3"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2",
+ "@ui5/webcomponents-tools": "2.4.0-rc.3",
"chromedriver": "^129.0.0"
}
}
diff --git a/packages/base/CHANGELOG.md b/packages/base/CHANGELOG.md
index 2e105440ddc7..88e4fd61a6fc 100644
--- a/packages/base/CHANGELOG.md
+++ b/packages/base/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-base
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
diff --git a/packages/base/package.json b/packages/base/package.json
index d75548d3cbd7..bf17332e273f 100644
--- a/packages/base/package.json
+++ b/packages/base/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-base",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.base",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
@@ -52,7 +52,7 @@
},
"devDependencies": {
"@openui5/sap.ui.core": "1.120.17",
- "@ui5/webcomponents-tools": "2.4.0-rc.2",
+ "@ui5/webcomponents-tools": "2.4.0-rc.3",
"chromedriver": "^129.0.0",
"clean-css": "^5.2.2",
"copy-and-watch": "^0.1.5",
diff --git a/packages/compat/CHANGELOG.md b/packages/compat/CHANGELOG.md
index adcbdfce3c8c..26b20d07d00a 100644
--- a/packages/compat/CHANGELOG.md
+++ b/packages/compat/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-compat
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-compat
diff --git a/packages/compat/package.json b/packages/compat/package.json
index 31098d5c2a3b..4b7e3a9d9ee9 100644
--- a/packages/compat/package.json
+++ b/packages/compat/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-compat",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.compat",
"ui5": {
"webComponentsPackage": true
@@ -45,13 +45,13 @@
"directory": "packages/compat"
},
"dependencies": {
- "@ui5/webcomponents": "2.4.0-rc.2",
- "@ui5/webcomponents-base": "2.4.0-rc.2",
- "@ui5/webcomponents-icons": "2.4.0-rc.2",
- "@ui5/webcomponents-theming": "2.4.0-rc.2"
+ "@ui5/webcomponents": "2.4.0-rc.3",
+ "@ui5/webcomponents-base": "2.4.0-rc.3",
+ "@ui5/webcomponents-icons": "2.4.0-rc.3",
+ "@ui5/webcomponents-theming": "2.4.0-rc.3"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2",
+ "@ui5/webcomponents-tools": "2.4.0-rc.3",
"chromedriver": "^129.0.0"
}
}
diff --git a/packages/create-package/CHANGELOG.md b/packages/create-package/CHANGELOG.md
index 6cdfa8a68d8c..5640257424b1 100644
--- a/packages/create-package/CHANGELOG.md
+++ b/packages/create-package/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/create-webcomponents-package
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/create-webcomponents-package
diff --git a/packages/create-package/package.json b/packages/create-package/package.json
index 9ca739967b80..912c3a581111 100644
--- a/packages/create-package/package.json
+++ b/packages/create-package/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/create-webcomponents-package",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: create package",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
diff --git a/packages/fiori/CHANGELOG.md b/packages/fiori/CHANGELOG.md
index de0d377bdf3f..76266d4af765 100644
--- a/packages/fiori/CHANGELOG.md
+++ b/packages/fiori/CHANGELOG.md
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+
+### Bug Fixes
+
+* **ui5-dynamic-page:** align header area with title and content ([#10053](https://github.com/SAP/ui5-webcomponents/issues/10053)) ([61e3dbd](https://github.com/SAP/ui5-webcomponents/commit/61e3dbd1f9a5b69c824cfcdae5c750d59585615a))
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
diff --git a/packages/fiori/package.json b/packages/fiori/package.json
index 5c027e568123..ae2d5b009608 100644
--- a/packages/fiori/package.json
+++ b/packages/fiori/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-fiori",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.fiori",
"ui5": {
"webComponentsPackage": true
@@ -53,14 +53,14 @@
"directory": "packages/fiori"
},
"dependencies": {
- "@ui5/webcomponents": "2.4.0-rc.2",
- "@ui5/webcomponents-base": "2.4.0-rc.2",
- "@ui5/webcomponents-icons": "2.4.0-rc.2",
- "@ui5/webcomponents-theming": "2.4.0-rc.2",
+ "@ui5/webcomponents": "2.4.0-rc.3",
+ "@ui5/webcomponents-base": "2.4.0-rc.3",
+ "@ui5/webcomponents-icons": "2.4.0-rc.3",
+ "@ui5/webcomponents-theming": "2.4.0-rc.3",
"@zxing/library": "^0.17.1"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2",
+ "@ui5/webcomponents-tools": "2.4.0-rc.3",
"chromedriver": "^129.0.0",
"lit": "^2.0.0"
}
diff --git a/packages/fiori/src/themes/ShellBar.css b/packages/fiori/src/themes/ShellBar.css
index 56dfc9d2d4ac..7cf316ea6843 100644
--- a/packages/fiori/src/themes/ShellBar.css
+++ b/packages/fiori/src/themes/ShellBar.css
@@ -3,6 +3,8 @@
:host(:not([hidden])) {
display: inline-block;
width: 100%;
+ background: var(--sapShellColor);
+ box-sizing: border-box;
}
:host {
@@ -19,7 +21,6 @@
display: flex;
justify-content: space-between;
align-items: center;
- background: var(--sapShellColor);
height: var(--_ui5_shellbar_root_height);
font-family: "72override", var(--sapFontFamily);
font-size: var(--sapFontSize);
@@ -178,7 +179,7 @@ slot[name="profile"] {
margin-inline-start: 0;
}
-:host([breakpoint-size="S"]) .ui5-shellbar-root {
+:host([breakpoint-size="S"]) {
padding: 0 1rem;
}
@@ -186,7 +187,7 @@ slot[name="profile"] {
padding: 0 1rem;
}
-:host([breakpoint-size="M"]) .ui5-shellbar-root {
+:host([breakpoint-size="M"]) {
padding: 0 2rem;
}
@@ -194,15 +195,15 @@ slot[name="profile"] {
padding: 0 2rem;
}
-:host([breakpoint-size="L"]) .ui5-shellbar-root {
+:host([breakpoint-size="L"]) {
padding: 0 2rem;
}
-:host([breakpoint-size="XL"]) .ui5-shellbar-root {
+:host([breakpoint-size="XL"]) {
padding: 0 3rem;
}
-:host([breakpoint-size="XXL"]) .ui5-shellbar-root {
+:host([breakpoint-size="XXL"]) {
padding: 0 3rem;
}
diff --git a/packages/icons-business-suite/CHANGELOG.md b/packages/icons-business-suite/CHANGELOG.md
index 39c6fb7d2257..69cec79bf1c5 100644
--- a/packages/icons-business-suite/CHANGELOG.md
+++ b/packages/icons-business-suite/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-icons-business-suite
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-icons-business-suite
diff --git a/packages/icons-business-suite/package.json b/packages/icons-business-suite/package.json
index b07cc2432907..e3d2de1111cc 100644
--- a/packages/icons-business-suite/package.json
+++ b/packages/icons-business-suite/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-icons-business-suite",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: SAP Fiori Tools icon set",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
@@ -28,9 +28,9 @@
"directory": "packages/icons-business-suite"
},
"dependencies": {
- "@ui5/webcomponents-base": "2.4.0-rc.2"
+ "@ui5/webcomponents-base": "2.4.0-rc.3"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2"
+ "@ui5/webcomponents-tools": "2.4.0-rc.3"
}
}
diff --git a/packages/icons-tnt/CHANGELOG.md b/packages/icons-tnt/CHANGELOG.md
index 832486ef55a0..f5f850f7d56d 100644
--- a/packages/icons-tnt/CHANGELOG.md
+++ b/packages/icons-tnt/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-icons-tnt
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-icons-tnt
diff --git a/packages/icons-tnt/package.json b/packages/icons-tnt/package.json
index a9e5fb0efa4a..ed255f4b4c69 100644
--- a/packages/icons-tnt/package.json
+++ b/packages/icons-tnt/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-icons-tnt",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: SAP Fiori Tools icon set",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
@@ -28,9 +28,9 @@
"directory": "packages/icons-tnt"
},
"dependencies": {
- "@ui5/webcomponents-base": "2.4.0-rc.2"
+ "@ui5/webcomponents-base": "2.4.0-rc.3"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2"
+ "@ui5/webcomponents-tools": "2.4.0-rc.3"
}
}
diff --git a/packages/icons/CHANGELOG.md b/packages/icons/CHANGELOG.md
index 5b85db4cbe23..c3964a773169 100644
--- a/packages/icons/CHANGELOG.md
+++ b/packages/icons/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-icons
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-icons
diff --git a/packages/icons/package.json b/packages/icons/package.json
index de441698e00c..955ebacb8f43 100644
--- a/packages/icons/package.json
+++ b/packages/icons/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-icons",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.SAP-icons",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
@@ -28,9 +28,9 @@
"directory": "packages/icons"
},
"dependencies": {
- "@ui5/webcomponents-base": "2.4.0-rc.2"
+ "@ui5/webcomponents-base": "2.4.0-rc.3"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2"
+ "@ui5/webcomponents-tools": "2.4.0-rc.3"
}
}
diff --git a/packages/localization/CHANGELOG.md b/packages/localization/CHANGELOG.md
index 99420ce3c9dd..5df3940fd7d0 100644
--- a/packages/localization/CHANGELOG.md
+++ b/packages/localization/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-localization
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-localization
diff --git a/packages/localization/package.json b/packages/localization/package.json
index ce32ecd29c90..5c56a0dd02e1 100644
--- a/packages/localization/package.json
+++ b/packages/localization/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-localization",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "Localization for UI5 Web Components",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
@@ -33,7 +33,7 @@
"@babel/generator": "^7.23.6",
"@babel/parser": "^7.23.6",
"@openui5/sap.ui.core": "1.120.17",
- "@ui5/webcomponents-tools": "2.4.0-rc.2",
+ "@ui5/webcomponents-tools": "2.4.0-rc.3",
"babel-plugin-amd-to-esm": "^2.0.3",
"chromedriver": "^129.0.0",
"estree-walk": "^2.2.0",
@@ -42,6 +42,6 @@
},
"dependencies": {
"@types/openui5": "^1.113.0",
- "@ui5/webcomponents-base": "2.4.0-rc.2"
+ "@ui5/webcomponents-base": "2.4.0-rc.3"
}
}
diff --git a/packages/main/CHANGELOG.md b/packages/main/CHANGELOG.md
index b35234796342..8ae1dd0a61cf 100644
--- a/packages/main/CHANGELOG.md
+++ b/packages/main/CHANGELOG.md
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+
+### Features
+
+* **ui5-tabcontainer:** style adjustments for transparent header ([#10064](https://github.com/SAP/ui5-webcomponents/issues/10064)) ([b5e596e](https://github.com/SAP/ui5-webcomponents/commit/b5e596e542a4fbd3f0643b15d2f4023be2079f5a))
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
diff --git a/packages/main/package.json b/packages/main/package.json
index 617ffe248580..c026f50b239e 100644
--- a/packages/main/package.json
+++ b/packages/main/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.main",
"ui5": {
"webComponentsPackage": true
@@ -50,15 +50,15 @@
"directory": "packages/main"
},
"dependencies": {
- "@ui5/webcomponents-base": "2.4.0-rc.2",
- "@ui5/webcomponents-icons": "2.4.0-rc.2",
- "@ui5/webcomponents-icons-business-suite": "2.4.0-rc.2",
- "@ui5/webcomponents-icons-tnt": "2.4.0-rc.2",
- "@ui5/webcomponents-localization": "2.4.0-rc.2",
- "@ui5/webcomponents-theming": "2.4.0-rc.2"
+ "@ui5/webcomponents-base": "2.4.0-rc.3",
+ "@ui5/webcomponents-icons": "2.4.0-rc.3",
+ "@ui5/webcomponents-icons-business-suite": "2.4.0-rc.3",
+ "@ui5/webcomponents-icons-tnt": "2.4.0-rc.3",
+ "@ui5/webcomponents-localization": "2.4.0-rc.3",
+ "@ui5/webcomponents-theming": "2.4.0-rc.3"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2",
+ "@ui5/webcomponents-tools": "2.4.0-rc.3",
"chromedriver": "^129.0.0",
"lit": "^2.0.0"
}
diff --git a/packages/main/src/SliderBase.ts b/packages/main/src/SliderBase.ts
index da01486bf8dd..e9ac5ff37560 100644
--- a/packages/main/src/SliderBase.ts
+++ b/packages/main/src/SliderBase.ts
@@ -693,16 +693,14 @@ abstract class SliderBase extends UI5Element {
}
_handleActionKeyPressBase(e: KeyboardEvent, affectedPropName: string) {
- const isUpAction = SliderBase._isIncreaseValueAction(e);
+ const isUpAction = SliderBase._isIncreaseValueAction(e, this.directionStart);
const isBigStep = SliderBase._isBigStepAction(e);
const currentValue = this[affectedPropName as keyof SliderBase] as number;
const min = this._effectiveMin;
const max = this._effectiveMax;
- // We need to take into consideration the effective direction of the slider - rtl or ltr.
- // While in ltr, the left arrow key decreases the value, in rtl it should actually increase it.
- let step = this.effectiveDir === "rtl" ? -this._effectiveStep : this._effectiveStep;
+ let step = this._effectiveStep;
// If the action key corresponds to a long step and the slider has more than 10 normal steps,
// make a jump of 1/10th of the Slider's length, otherwise just use the normal step property.
@@ -719,11 +717,11 @@ abstract class SliderBase extends UI5Element {
return isUpAction ? step : step * -1;
}
- static _isDecreaseValueAction(e: KeyboardEvent) {
- return isDown(e) || isDownCtrl(e) || isLeft(e) || isLeftCtrl(e) || isMinus(e) || isPageDown(e);
- }
+ static _isIncreaseValueAction(e: KeyboardEvent, directionStart: DirectionStart) {
+ if (directionStart === "right") {
+ return isUp(e) || isUpCtrl(e) || isLeft(e) || isLeftCtrl(e) || isPlus(e) || isPageUp(e);
+ }
- static _isIncreaseValueAction(e: KeyboardEvent) {
return isUp(e) || isUpCtrl(e) || isRight(e) || isRightCtrl(e) || isPlus(e) || isPageUp(e);
}
diff --git a/packages/main/src/themes/sap_fiori_3/Button-parameters.css b/packages/main/src/themes/sap_fiori_3/Button-parameters.css
index 1aa2e3451e1d..9c259b47a1af 100644
--- a/packages/main/src/themes/sap_fiori_3/Button-parameters.css
+++ b/packages/main/src/themes/sap_fiori_3/Button-parameters.css
@@ -8,7 +8,7 @@
--_ui5_button_icon_font_size: 1rem;
--_ui5_button_text_shadow: none;
--_ui5_button_emphasized_focused_border: 0.0625rem dotted var(--sapContent_ContrastFocusColor);
- --_ui5_button_emphasized_focused_border_before: 0.0625rem solid var(--sapContent_FocusColor);
+ --_ui5_button_emphasized_focused_border_before: unset;
--_ui5_button_emphasized_outline: 1px solid var(--sapContent_FocusColor);
--_ui5_button_emphasized_focused_border_color: var(--sapContent_ContrastFocusColor);
--_ui5_button_emphasized_focused_active_border_color: var(--sapContent_ContrastFocusColor);
diff --git a/packages/main/src/themes/sap_fiori_3_dark/Button-parameters.css b/packages/main/src/themes/sap_fiori_3_dark/Button-parameters.css
index 1aa2e3451e1d..9c259b47a1af 100644
--- a/packages/main/src/themes/sap_fiori_3_dark/Button-parameters.css
+++ b/packages/main/src/themes/sap_fiori_3_dark/Button-parameters.css
@@ -8,7 +8,7 @@
--_ui5_button_icon_font_size: 1rem;
--_ui5_button_text_shadow: none;
--_ui5_button_emphasized_focused_border: 0.0625rem dotted var(--sapContent_ContrastFocusColor);
- --_ui5_button_emphasized_focused_border_before: 0.0625rem solid var(--sapContent_FocusColor);
+ --_ui5_button_emphasized_focused_border_before: unset;
--_ui5_button_emphasized_outline: 1px solid var(--sapContent_FocusColor);
--_ui5_button_emphasized_focused_border_color: var(--sapContent_ContrastFocusColor);
--_ui5_button_emphasized_focused_active_border_color: var(--sapContent_ContrastFocusColor);
diff --git a/packages/main/src/themes/sap_fiori_3_hcb/Button-parameters.css b/packages/main/src/themes/sap_fiori_3_hcb/Button-parameters.css
index 0966b30072df..9856578942d4 100644
--- a/packages/main/src/themes/sap_fiori_3_hcb/Button-parameters.css
+++ b/packages/main/src/themes/sap_fiori_3_hcb/Button-parameters.css
@@ -3,6 +3,7 @@
:root {
--_ui5_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor);
--_ui5_button_focused_border_radius: 0.25rem;
+ --_ui5_button_emphasized_focused_border_before: var(--_ui5_button_focused_border);
--_ui5_button_focus_width: 1px;
--_ui5_button_text_shadow: none;
--_ui5_button_emphasized_outline: 0.125rem dotted var(--sapContent_FocusColor);
diff --git a/packages/main/src/themes/sap_fiori_3_hcw/Button-parameters.css b/packages/main/src/themes/sap_fiori_3_hcw/Button-parameters.css
index 0966b30072df..9856578942d4 100644
--- a/packages/main/src/themes/sap_fiori_3_hcw/Button-parameters.css
+++ b/packages/main/src/themes/sap_fiori_3_hcw/Button-parameters.css
@@ -3,6 +3,7 @@
:root {
--_ui5_button_focused_border: 0.125rem dotted var(--sapContent_FocusColor);
--_ui5_button_focused_border_radius: 0.25rem;
+ --_ui5_button_emphasized_focused_border_before: var(--_ui5_button_focused_border);
--_ui5_button_focus_width: 1px;
--_ui5_button_text_shadow: none;
--_ui5_button_emphasized_outline: 0.125rem dotted var(--sapContent_FocusColor);
diff --git a/packages/main/test/specs/Slider.spec.js b/packages/main/test/specs/Slider.spec.js
index 9220cecbafb0..9b95b5d2c899 100644
--- a/packages/main/test/specs/Slider.spec.js
+++ b/packages/main/test/specs/Slider.spec.js
@@ -192,7 +192,7 @@ describe("Slider elements - tooltip, step, tickmarks, labels", () => {
await slider.click();
assert.strictEqual(await slider.getProperty("_tooltipVisibility"), "visible", "Slider tooltip visibility property should be 'visible'");
-
+
await sliderTooltipInput.click();
assert.strictEqual(await sliderTooltipInput.getProperty("focused"), true, "The tooltip is not closed and the input is focused");
@@ -282,7 +282,7 @@ describe("Slider elements - tooltip, step, tickmarks, labels", () => {
await browser.keys("ArrowUp");
assert.strictEqual(await slider.getProperty("value"), 1, "The value is not changed on arrow up");
-
+
await browser.keys("ArrowDown");
assert.strictEqual(await slider.getProperty("value"), 1, "The value is not changed on arrow down");
@@ -654,6 +654,25 @@ describe("Testing resize handling and RTL support", () => {
assert.strictEqual(await slider.getProperty("value"), 1, "Slider current value should be 1");
});
+ it("Testing RTL KBH support - arrow up and down", async () => {
+ const slider = await browser.$("#basic-slider-rtl");
+ const sliderHandleContainer = await slider.shadow$(".ui5-slider-handle-container");
+
+ await slider.setProperty("value", 0);
+ assert.strictEqual((await sliderHandleContainer.getCSSProperty("right")).value, "0px", "Initially if no value is set, the Slider handle is at the right of the Slider");
+
+ await slider.keys("ArrowUp");
+ await slider.keys("ArrowUp");
+
+ assert.strictEqual(await sliderHandleContainer.getAttribute("style"), "right: 20%;", "Slider handle should be 20% from the right of the slider");
+ assert.strictEqual(await slider.getProperty("value"), 2, "Slider current value should be 2");
+
+ await slider.keys("ArrowDown");
+
+ assert.strictEqual(await sliderHandleContainer.getAttribute("style"), "right: 10%;", "Slider handle should be 10% from the right of the slider");
+ assert.strictEqual(await slider.getProperty("value"), 1, "Slider current value should be 1");
+ });
+
it("Should hide all labels except the first and the last one, if there is not enough space for all of them", async () => {
const slider = await browser.$("#slider-tickmarks-tooltips-labels");
diff --git a/packages/theming/CHANGELOG.md b/packages/theming/CHANGELOG.md
index 788e796169b6..64d18d9a7140 100644
--- a/packages/theming/CHANGELOG.md
+++ b/packages/theming/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-theming
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-theming
diff --git a/packages/theming/package.json b/packages/theming/package.json
index 1a4ddebf5667..b3bcebe137a8 100644
--- a/packages/theming/package.json
+++ b/packages/theming/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-theming",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.theming",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
@@ -31,10 +31,10 @@
},
"dependencies": {
"@sap-theming/theming-base-content": "11.17.1",
- "@ui5/webcomponents-base": "2.4.0-rc.2"
+ "@ui5/webcomponents-base": "2.4.0-rc.3"
},
"devDependencies": {
- "@ui5/webcomponents-tools": "2.4.0-rc.2",
+ "@ui5/webcomponents-tools": "2.4.0-rc.3",
"globby": "^13.1.1",
"json-beautify": "^1.1.1",
"nps": "^5.10.0",
diff --git a/packages/tools/CHANGELOG.md b/packages/tools/CHANGELOG.md
index 19fad381383f..ba14c6faf3d1 100644
--- a/packages/tools/CHANGELOG.md
+++ b/packages/tools/CHANGELOG.md
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+
+### Bug Fixes
+
+* dev-server correctly imports yargs ([#10048](https://github.com/SAP/ui5-webcomponents/issues/10048)) ([7b5aa5e](https://github.com/SAP/ui5-webcomponents/commit/7b5aa5ebdddbbc0493f4699c1a74db497e22368b))
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
**Note:** Version bump only for package @ui5/webcomponents-tools
diff --git a/packages/tools/package.json b/packages/tools/package.json
index 86463eae058d..6c47be680eda 100644
--- a/packages/tools/package.json
+++ b/packages/tools/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-tools",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"description": "UI5 Web Components: webcomponents.tools",
"author": "SAP SE (https://www.sap.com)",
"license": "Apache-2.0",
diff --git a/packages/website/CHANGELOG.md b/packages/website/CHANGELOG.md
index b3a494026be1..5bba175306ce 100644
--- a/packages/website/CHANGELOG.md
+++ b/packages/website/CHANGELOG.md
@@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+# [2.4.0-rc.3](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.2...v2.4.0-rc.3) (2024-10-28)
+
+**Note:** Version bump only for package @ui5/webcomponents-website
+
+
+
+
+
# [2.4.0-rc.2](https://github.com/SAP/ui5-webcomponents/compare/v2.4.0-rc.1...v2.4.0-rc.2) (2024-10-24)
diff --git a/packages/website/docs/_components_pages/main/TabContainer/TabContainer.mdx b/packages/website/docs/_components_pages/main/TabContainer/TabContainer.mdx
index 4cd21548227f..676a5d95788a 100644
--- a/packages/website/docs/_components_pages/main/TabContainer/TabContainer.mdx
+++ b/packages/website/docs/_components_pages/main/TabContainer/TabContainer.mdx
@@ -12,6 +12,7 @@ import NestedTabs from "../../../_samples/main/TabContainer/NestedTabs/NestedTab
import ReorderTabs from "../../../_samples/main/TabContainer/ReorderTabs/ReorderTabs.md";
import ReorderTabsMaxNestingLevel from "../../../_samples/main/TabContainer/ReorderTabsMaxNestingLevel/ReorderTabsMaxNestingLevel.md";
import ReorderTabsFixedTabs from "../../../_samples/main/TabContainer/ReorderTabsFixedTabs/ReorderTabsFixedTabs.md";
+import TransparentDesign from "../../../_samples/main/TabContainer/TransparentDesign/TransparentDesign.md";
<%COMPONENT_OVERVIEW%>
@@ -52,3 +53,8 @@ It can be switched to "StartAndEnd":
### Reorder Tabs with Fixed Tabs
+
+### Transparent design
+
+The inner TabContainer has headerBackgroundDesign and contentBackgroundDesign set to "Transparent":
+
diff --git a/packages/website/docs/_samples/main/TabContainer/TransparentDesign/TransparentDesign.md b/packages/website/docs/_samples/main/TabContainer/TransparentDesign/TransparentDesign.md
new file mode 100644
index 000000000000..ffccbf6dd13e
--- /dev/null
+++ b/packages/website/docs/_samples/main/TabContainer/TransparentDesign/TransparentDesign.md
@@ -0,0 +1,4 @@
+import html from '!!raw-loader!./sample.html';
+import js from '!!raw-loader!./main.js';
+
+
\ No newline at end of file
diff --git a/packages/website/docs/_samples/main/TabContainer/TransparentDesign/main.js b/packages/website/docs/_samples/main/TabContainer/TransparentDesign/main.js
new file mode 100644
index 000000000000..83c3dd58d68e
--- /dev/null
+++ b/packages/website/docs/_samples/main/TabContainer/TransparentDesign/main.js
@@ -0,0 +1,3 @@
+import "@ui5/webcomponents/dist/TabContainer.js"
+import "@ui5/webcomponents/dist/Tab.js"
+import "@ui5/webcomponents/dist/Text.js"
\ No newline at end of file
diff --git a/packages/website/docs/_samples/main/TabContainer/TransparentDesign/sample.html b/packages/website/docs/_samples/main/TabContainer/TransparentDesign/sample.html
new file mode 100644
index 000000000000..125c4b20954e
--- /dev/null
+++ b/packages/website/docs/_samples/main/TabContainer/TransparentDesign/sample.html
@@ -0,0 +1,35 @@
+
+
+
+
+
+
+ Sample
+
+
+
+
+
+
+
+
+ Lorem ipsum dolor sit amet consectetur adipisicing elit. Expedita voluptates accusamus est quibusdam inventore ipsam?
+
+
+ Accusamus minus aperiam sunt ipsam eos quos et maxime facilis tempora neque ratione nemo laborum expedita aliquid officiis nisi, necessitatibus quasi distinctio?
+
+
+ Dolores totam perferendis numquam incidunt obcaecati, id quo at alias rem deserunt praesentium repellat ipsum commodi consequuntur veniam et ducimus animi qui nobis accusantium tenetur eveniet culpa non!
+
+
+
+
+ Accusamus minus aperiam sunt ipsam eos quos et maxime facilis tempora neque ratione nemo laborum expedita aliquid officiis nisi, necessitatibus quasi distinctio?
+
+
+
+
+
+
+
+
diff --git a/packages/website/package.json b/packages/website/package.json
index bd4033494dd5..b979a4cc200b 100644
--- a/packages/website/package.json
+++ b/packages/website/package.json
@@ -1,6 +1,6 @@
{
"name": "@ui5/webcomponents-website",
- "version": "2.4.0-rc.2",
+ "version": "2.4.0-rc.3",
"private": true,
"scripts": {
"generate-local-cdn": "rimraf ./local-cdn && node ./build-scripts/local-cdn.mjs",