-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sine integration test #110
Add sine integration test #110
Conversation
This adds a nearly identical copy of the sine example. Wouldn't it be more elegant to just let the ci compile the existing example? |
Yeah, I'm probably gonna remove that integration test. My understanding is that |
Can't we just let the ci run the examples? Like
If one of them fails that should fail the job. |
Oh there's not really a good reason. The OCD in me says "Because an example is not a test and CI is for tests". I took your advice and added the the example run to CI. Anyway, @HEnquist I bumped the version to |
Looks great! |
It's not really. I mostly went with it to be consistent with the ci in coreaudio-sys and use an explicit version of LLVM. The existing llvm install parts use At some point it'd be good to test multiple version of llvm to avoid things like RustAudio/coreaudio-sys#85. |
Follow up from #109.