-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rcs #273
Merged
Merged
Improve rcs #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paweł Liberadzki <[email protected]>
Signed-off-by: Paweł Liberadzki <[email protected]>
Signed-off-by: Paweł Liberadzki <[email protected]>
Signed-off-by: Paweł Liberadzki <[email protected]>
Signed-off-by: Paweł Liberadzki <[email protected]>
Signed-off-by: Paweł Liberadzki <[email protected]>
PawelLiberadzki
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks fine, considering it is a pull to feature branch.
msz-rai
added a commit
that referenced
this pull request
Mar 26, 2024
* Add debug development chnages. Signed-off-by: Paweł Liberadzki <[email protected]> * Add fixes for RCS calculation. Signed-off-by: Paweł Liberadzki <[email protected]> * Reduce mess in RCS calculation kernel. Signed-off-by: Paweł Liberadzki <[email protected]> * Remove not used variable. Signed-off-by: Paweł Liberadzki <[email protected]> * Remove not necessary dependency on hit position. Signed-off-by: Paweł Liberadzki <[email protected]> * Compute radar energy locally to be independent on lidar pose * Make update to lower RCS value near 90 and -90 degrees. Signed-off-by: Paweł Liberadzki <[email protected]> * Cleanup radar postprocessing node (revert clustering changes) * Make log constexpr (maybe perf optimization) * Get rid of M_PIf * Remove calculateMat function --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Paweł Liberadzki <[email protected]>
msz-rai
added a commit
that referenced
this pull request
Mar 26, 2024
* Add power computation * Fix static_asserts in core.h * Working prototype, need to fix values * Make updates to radar power calculation. Make minor fixes. Signed-off-by: Paweł Liberadzki <[email protected]> * Add additional radar parameters * Add noise params and RCS NaN check * Fix clustering test * Fix reflecting polarization. Signed-off-by: Paweł Liberadzki <[email protected]> * Change not necessary complex to scalar. Signed-off-by: Paweł Liberadzki <[email protected]> * Fix ray dir (to reflected dir) for scattered field calculation. Signed-off-by: Paweł Liberadzki <[email protected]> * Update azimuth and elevation angles in ray generation in RCS radar test. Signed-off-by: Paweł Liberadzki <[email protected]> * Improve rcs (#273) * Add debug development chnages. Signed-off-by: Paweł Liberadzki <[email protected]> * Add fixes for RCS calculation. Signed-off-by: Paweł Liberadzki <[email protected]> * Reduce mess in RCS calculation kernel. Signed-off-by: Paweł Liberadzki <[email protected]> * Remove not used variable. Signed-off-by: Paweł Liberadzki <[email protected]> * Remove not necessary dependency on hit position. Signed-off-by: Paweł Liberadzki <[email protected]> * Compute radar energy locally to be independent on lidar pose * Make update to lower RCS value near 90 and -90 degrees. Signed-off-by: Paweł Liberadzki <[email protected]> * Cleanup radar postprocessing node (revert clustering changes) * Make log constexpr (maybe perf optimization) * Get rid of M_PIf * Remove calculateMat function --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Paweł Liberadzki <[email protected]> * Radar power as power received + noise * Cleanup parameters * Remove rcsAngleDistributionTest * Review changes --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Paweł Liberadzki <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]>
msz-rai
added a commit
that referenced
this pull request
Jun 11, 2024
* Add power computation * Fix static_asserts in core.h * Working prototype, need to fix values * Make updates to radar power calculation. Make minor fixes. Signed-off-by: Paweł Liberadzki <[email protected]> * Add additional radar parameters * Add noise params and RCS NaN check * Fix clustering test * Fix reflecting polarization. Signed-off-by: Paweł Liberadzki <[email protected]> * Change not necessary complex to scalar. Signed-off-by: Paweł Liberadzki <[email protected]> * Fix ray dir (to reflected dir) for scattered field calculation. Signed-off-by: Paweł Liberadzki <[email protected]> * Update azimuth and elevation angles in ray generation in RCS radar test. Signed-off-by: Paweł Liberadzki <[email protected]> * Improve rcs (#273) * Add debug development chnages. Signed-off-by: Paweł Liberadzki <[email protected]> * Add fixes for RCS calculation. Signed-off-by: Paweł Liberadzki <[email protected]> * Reduce mess in RCS calculation kernel. Signed-off-by: Paweł Liberadzki <[email protected]> * Remove not used variable. Signed-off-by: Paweł Liberadzki <[email protected]> * Remove not necessary dependency on hit position. Signed-off-by: Paweł Liberadzki <[email protected]> * Compute radar energy locally to be independent on lidar pose * Make update to lower RCS value near 90 and -90 degrees. Signed-off-by: Paweł Liberadzki <[email protected]> * Cleanup radar postprocessing node (revert clustering changes) * Make log constexpr (maybe perf optimization) * Get rid of M_PIf * Remove calculateMat function --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Paweł Liberadzki <[email protected]> * Radar power as power received + noise * Cleanup parameters * Remove rcsAngleDistributionTest * Review changes --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Paweł Liberadzki <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.