Building rgl statically

[AlgoryxJosef]

Hi, I wonder if adding the possibility to build the rgl library static is something you have looked into?
Currently, in the root CMakeLists.txt we se that building as a shared library is hardcoded:

add_library(RobotecGPULidar SHARED ...)

Adding this as a cmake option would be a great feature, but I don't know if building as SHARED only is something you do for technical reasons.

All the best,
Josef

[PawelLiberadzki]

Hi @AlgoryxJosef, thank you for this comment. All of current applications of RGL utilize it as shared library, so we did not put much effort to investigate static build. If you have maybe checked this yourself and it works, we would greatly appreciate a PR for it.

Best regards,
Pawel

[AlgoryxJosef]

For reference, I just tried locally by setting the following in CMakeLists.txt:

add_library(RobotecGPULidar STATIC ...)

I get link errors for test/RobotecGPULidar_test.exe.

Here is a snippet:

spdlog.lib(spdlog.cpp.obj) : error LNK2005: "public: __cdecl spdlog::details::log_msg::log_msg(struct spdlog::source_loc,class fmt::v8::basic_string_view<char>,enum spdlog::level::level_enum,class fmt::v8::basic_string_view<char>)" (??0log_msg@details@spdlog@@QEAA@Usource_loc@2@V?$basic_string_view@D@v8@fmt@@W4level_enum@level@2@1@Z) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "public: __cdecl spdlog::details::log_msg::log_msg(class std::chrono::time_point<struct std::chrono::system_clock,class std::chrono::duration<__int64,struct std::ratio<1,10000000> > >,struct spdlog::source_loc,class fmt::v8::basic_string_view<char>,enum spdlog::level::level_enum,class fmt::v8::basic_string_view<char>)" (??0log_msg@details@spdlog@@QEAA@V?$time_point@Usystem_clock@chrono@std@@V?$duration@_JU?$ratio@$00$0JIJGIA@@std@@@23@@chrono@std@@Usource_loc@2@V?$basic_string_view@D@v8@fmt@@W4level_enum@level@2@2@Z) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "public: __cdecl spdlog::details::log_msg_buffer::log_msg_buffer(struct spdlog::details::log_msg const &)" (??0log_msg_buffer@details@spdlog@@QEAA@AEBUlog_msg@12@@Z) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "public: class spdlog::details::log_msg_buffer & __cdecl spdlog::details::log_msg_buffer::operator=(class spdlog::details::log_msg_buffer &&)" (??4log_msg_buffer@details@spdlog@@QEAAAEAV012@$$QEAV012@@Z) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "unsigned __int64 __cdecl spdlog::details::os::_thread_id(void)" (?_thread_id@os@details@spdlog@@YA_KXZ) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "public: bool __cdecl spdlog::details::backtracer::enabled(void)const " (?enabled@backtracer@details@spdlog@@QEBA_NXZ) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "public: void __cdecl spdlog::logger::flush(void)" (?flush@logger@spdlog@@QEAAXXZ) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "protected: void __cdecl spdlog::logger::log_it_(struct spdlog::details::log_msg const &,bool,bool)" (?log_it_@logger@spdlog@@IEAAXAEBUlog_msg@details@2@_N1@Z) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "class std::chrono::time_point<struct std::chrono::system_clock,class std::chrono::duration<__int64,struct std::ratio<1,10000000> > > __cdecl spdlog::details::os::now(void)" (?now@os@details@spdlog@@YA?AV?$time_point@Usystem_clock@chrono@std@@V?$duration@_JU?$ratio@$00$0JIJGIA@@std@@@23@@chrono@std@@XZ) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "public: void __cdecl spdlog::details::backtracer::push_back(struct spdlog::details::log_msg const &)" (?push_back@backtracer@details@spdlog@@QEAAXAEBUlog_msg@23@@Z) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "unsigned __int64 __cdecl spdlog::details::os::thread_id(void)" (?thread_id@os@details@spdlog@@YA_KXZ) already defined in loggingTests.cpp.obj
spdlog.lib(spdlog.cpp.obj) : error LNK2005: "private: void __cdecl spdlog::details::log_msg_buffer::update_string_views(void)" (?update_string_views@log_msg_buffer@details@spdlog@@AEAAXXZ) already defined in loggingTests.cpp.obj
spdlog.lib(fmt.cpp.obj) : error LNK2005: "public: __cdecl fmt::v8::detail::utf8_to_utf16::utf8_to_utf16(class fmt::v8::basic_string_view<char>)" (??0utf8_to_utf16@detail@v8@fmt@@QEAA@V?$basic_string_view@D@23@@Z) already defined in asyncStressTest.cpp.obj
spdlog.lib(fmt.cpp.obj) : error LNK2005: "public: void __cdecl fmt::v8::detail::error_handler::on_error(char const *)" (?on_error@error_handler@detail@v8@fmt@@QEAAXPEBD@Z) already defined in asyncStressTest.cpp.obj
spdlog.lib(fmt.cpp.obj) : error LNK2005: "void __cdecl fmt::v8::detail::print(struct _iobuf *,class fmt::v8::basic_string_view<char>)" (?print@detail@v8@fmt@@YAXPEAU_iobuf@@V?$basic_string_view@D@23@@Z) already defined in asyncStressTest.cpp.obj
spdlog.lib(fmt.cpp.obj) : error LNK2005: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl fmt::v8::vformat(class fmt::v8::basic_string_view<char>,class fmt::v8::basic_format_args<class fmt::v8::basic_format_context<class fmt::v8::appender,char> >)" (?vformat@v8@fmt@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$basic_string_view@D@12@V?$basic_format_args@V?$basic_format_context@Vappender@v8@fmt@@D@v8@fmt@@@12@@Z) already defined in asyncStressTest.cpp.obj

Building with Visual Studio 2019 on Windows.
I don't have the resources to investigate this further myself, but perhaps this is useful input to you if you decide to add this.

Best regards,
Josef

[PawelLiberadzki]

Thank you, this is obviously a useful information. I made a ticket referring to this discussion in our internal backlog.

Best regards,
Pawel