Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tel URI support - in SipCall #8

Open
tzieleniewski opened this issue Mar 8, 2016 · 2 comments
Open

Tel URI support - in SipCall #8

tzieleniewski opened this issue Mar 8, 2016 · 2 comments

Comments

@tzieleniewski
Copy link

Hi,

I'd like to request the addition of the Tel URI support to the SipCall class.
The current implementation returns with the "Unsupported URI Scheme" error, when the Tel URI string is provided as the toUri parameter in initiateOutgoingMessage and initiateOutgoingCall methods.

protected boolean initiateOutgoingCall(String fromUri, String toUri, String viaNonProxyRoute,
      MessageListener respListener, ArrayList<Header> additionalHeaders,
      ArrayList<Header> replaceHeaders, String body) {
    ..
    URI request_uri = addr_factory.createURI(toUri);
      if (request_uri.isSipURI() == false) {
        setReturnCode(SipSession.UNSUPPORTED_URI_SCHEME);
        setErrorMessage("URI " + toUri + " is not a Sip URI");
        return false;
      }
    ..
}

Godspeed
Tomasz Krzysztof Zieleniewski

@deruelle
Copy link
Member

deruelle commented Mar 8, 2016

Hi @tzieleniewski

Do you want to take a stab at it and contribute this new feature + add the relevant test cases to confirm it's working properly ?

@tzieleniewski
Copy link
Author

To do that it requires my employee assignment. We are contributing as ProIDS team.
At the moment I am to much involved in other activities.
So considering my contribution I deem this is to be done but not now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants