You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The scheme parameter accepts either a string name of a classifier (e.g. EqualInterval) or a fitted mapclassify object (e.g. mc.EqualInterval(df, k=5)). The following changes ought to be made:
Currently discrete categorical binning is only possible by passing the string "categorical" to the scheme parameter. The problem is that this magic value is not at all discoverable. It really need to have an equivalent mapclassify expression: e.g. mc.Discrete.
Also, this string should be renamed to "discrete", as "categorical" is confusing, and not a good name for a mapclassify scheme.
mapclassify schemes need to be create-able in unfitted form, and you should be able to pass both an unfitted and fitted scheme to geoplot. Passing a fitted scheme is necessary for the "scheme reuse" feature, whilst passing an unfitted scheme is necessary for palatable input to plots that generate data just-in-time (e.g. quadtree), and thus are categorically opaque to the user.
Both of these changes require contribs to mapclassify.
The text was updated successfully, but these errors were encountered:
The
scheme
parameter accepts either a string name of a classifier (e.g.EqualInterval
) or a fittedmapclassify
object (e.g.mc.EqualInterval(df, k=5)
). The following changes ought to be made:Currently discrete categorical binning is only possible by passing the string
"categorical"
to thescheme
parameter. The problem is that this magic value is not at all discoverable. It really need to have an equivalentmapclassify
expression: e.g.mc.Discrete
.Also, this string should be renamed to
"discrete"
, as"categorical"
is confusing, and not a good name for amapclassify
scheme.See Propogate legend_values and legend_labels to colorbar legend #144 for discussion and a clear use case.
mapclassify
schemes need to be create-able in unfitted form, and you should be able to pass both an unfitted and fitted scheme togeoplot
. Passing a fitted scheme is necessary for the "scheme reuse" feature, whilst passing an unfitted scheme is necessary for palatable input to plots that generate data just-in-time (e.g.quadtree
), and thus are categorically opaque to the user.Both of these changes require contribs to
mapclassify
.The text was updated successfully, but these errors were encountered: