Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the 7zip installation detection on windows-build-qt-static.ps1 needs work #34

Open
divinity76 opened this issue Aug 13, 2016 · 2 comments

Comments

@divinity76
Copy link

divinity76 commented Aug 13, 2016

i have 7-zip installed in E:\Program Files\7-Zip (because my C:\ is a small SSD), and the installer failed to detect 7zip being installed. looking at the source, it's not surprising:

function Get-7zip
{
    $Exe = "C:\Program Files\7-Zip\7z.exe"
    if (-not (Test-Path $Exe)) {
        $Exe = "C:\Program Files (x86)\7-Zip\7z.exe"
    }
    if (-not (Test-Path $Exe)) {
        Exit-Script "7-zip not found, install it first, see http://www.7-zip.org/"
    }
    $Exe
}
@Risca
Copy link
Member

Risca commented Aug 14, 2016

I believe @dalehamel added that script a long time ago, but I don't know if it's used. I've used the manual instructions in static qt build notes.txt when I've made a release

@dalehamel
Copy link
Member

I don't think it should be needed anymore

On Sunday, 14 August 2016, Patrik Dahlström [email protected]
wrote:

I believe @dalehamel https://github.com/dalehamel added that script a
long time ago, but I don't know if it's used. I've used the manual
instructions in static qt build notes.txt when I've made a release


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#34 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlwd27Rw_Q-G9IE7LLRB0IB4rLsB1Vbks5qfwqpgaJpZM4JjvVE
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants