Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Replace dt in AppMosaic to make it more versatile and accessible #1294

Open
eddybrando opened this issue Jan 11, 2021 · 0 comments
Open

Replace dt in AppMosaic to make it more versatile and accessible #1294

eddybrando opened this issue Jan 11, 2021 · 0 comments
Labels
accessibility Issues related to accessibility. code quality Issues related to code health like refactors and cleanups. good first issue Good issues for newcomers.

Comments

@eddybrando
Copy link
Collaborator

eddybrando commented Jan 11, 2021

In the AppMosaic component, we are currently using description lists (<dl>), which made total sense for its initial usage in the home page, but could restrict the reusability of this component in other scenarios.

Since we recently refactored the component in order to reuse it, it may be a good time to think about this.

If we were to pass to the AppMosaic a list of mosaicElements which are not name-value groups, we wouldn't be using the description list correctly (spec: https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element).

This could be particularly problematic for screen readers, which may hint the user about a text inside a <dd> tag being the description of a text inside a <dt> tag, which wouldn't be always the case.

@eddybrando eddybrando added code quality Issues related to code health like refactors and cleanups. accessibility Issues related to accessibility. labels Jan 11, 2021
@eddybrando eddybrando added good first issue Good issues for newcomers. size: S labels Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Issues related to accessibility. code quality Issues related to code health like refactors and cleanups. good first issue Good issues for newcomers.
Projects
None yet
Development

No branches or pull requests

1 participant