Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forks policy? #7

Open
fernandofig opened this issue May 22, 2020 · 1 comment
Open

Forks policy? #7

fernandofig opened this issue May 22, 2020 · 1 comment

Comments

@fernandofig
Copy link

There a few plugins for TShock that I use on my own server. The authors of these plugins are either taking their time to update them, or they've dropped maintenance on them completely a long time ago.

So I took it upon myself to update these plugins - at least on the plugins I use, the required changes were simple enough.

But now I'm in a situation in which I want to provide the updated / 4.4.0-compatible versions of these plugins for the community, but I also don't want this to mean I'm fully taking over development of these plugins long term.

So I went through the standard OSS development workflow - forked the repos, updated the code, and sent a pull request to the original authors. However, as per the 1st paragraph, I have no reason to believe they'll merge my changes in a timely manner, if at all.

I want these plugins listed on your Plugins list for the benefit of the community, but I have a few quandaries:

  • I'm not sure which source to reference: my fork, the original (which at this point in time is obsolete code), or (somehow) both;
  • I'm not sure if I'm even allowed do submit the plugins to be listed, since I'm not their original author.
@hakusaro
Copy link
Member

Broadly speaking you can submit a pull request — just make a subsection with the same heading level and a divider for “community updated plugins.” Same process as normal but I would list that they’re unsupported and may not be fixed in the future. Reference both the original and the fork for source and credit the original author as well as yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants