Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split alumini section to year wise pages #17

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shrijitsingh99
Copy link
Collaborator

@shrijitsingh99 shrijitsingh99 commented Sep 9, 2020

Having all the alumni in one-page increases page load time, especially as members get added.
having separate pages for each year will help maintain a database of alumni and also add year specific achievements etc. or any other information if needed in the future.

TODO:

  1. Add pages for years before 2017
  2. Cleanup the current team page and remove mentors from there
  3. Add a navigation bar (or something of that sort) to switch between teams from each year
  4. Add a banner of the entire team's photo from that year
  5. Remove 343aae3 once ready for merge

Demos:
https://shrijitsingh.com/projectmanas.in/team
https://shrijitsingh.com/projectmanas.in/team/2017

TODO After this PR:

  1. Fill alumni information for each year
  2. Migrate profile images to Imgur
  3. Do not use PNG for profile images, use JPG

@shrijitsingh99
Copy link
Collaborator Author

shrijitsingh99 commented Sep 9, 2020

@JoshiNaman Any ideas you had in mind for year-wise team pages? Also would be of great help if you could help build alumini.yaml file.

@shrijitsingh99
Copy link
Collaborator Author

Some points to discuss:

  1. What should be the year of a MANAS batch: the year they join MANAS or the year they join college?
  2. Do we remove the picture changing effect for alumni or leave it be?
  3. Do we mention the year and months they held the position in the team?
  4. Do we default (without hovering) position in the team or current designation

@Sarath18
Copy link
Contributor

  1. What should be the year of a MANAS batch: the year they join MANAS or the year they join college?

What if we display the year they were part of Project MANAS? For example 2018-19

  1. Do we remove the picture changing effect for alumni or leave it be?

We can add the effect for all the people who have a second image. I don't foresee any problems. We can ask them (people with the second image) if they want that effect to be displayed or not.

  1. Do we mention the year and months they held the position in the team?

I think we should definitely mention the year and position. Not sure about months.

  1. Do we default (without hovering) position in the team or current designation

I think this is a good idea.

Copy link
Contributor

@Sarath18 Sarath18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the broken profile links

Comment on lines +47 to +48
linkedin: https://www.linkedin.com/in/surampalli-rakesh-450213160/
github: https://github.com/rakeshsurampalli #Mech Head
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin: https://www.linkedin.com/in/surampalli-rakesh-450213160/
github: https://github.com/rakeshsurampalli #Mech Head
linkedin: https://www.linkedin.com/in/arya-karani-78424514a/
github: #Mech Head

image: 13.jpeg
facebook: https://www.facebook.com/sarathkrishnan.ramesh
mail: mailto:[email protected]
linkedin: https://www.linkedin.com/in/sarathkrishnan-ramesh-0a75a315b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin: https://www.linkedin.com/in/sarathkrishnan-ramesh-0a75a315b
linkedin: https://www.linkedin.com/in/sarathkrishnan-ramesh

image: 46.jpeg
facebook: https://w ww.facebook.com/shivanshu.agarwal.965
mail: mailto:[email protected]
linkedin: https://www.linkedin.com/in/shivansu-agarwal-53b625136
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin: https://www.linkedin.com/in/shivansu-agarwal-53b625136
linkedin: https://www.linkedin.com/in/shivanshu-agarwal-53b625136

image: rakshit.png
facebook: https://www.facebook.com/rakshit.jain.378
mail: mailto:[email protected]
linkedin:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin:
linkedin: https://www.linkedin.com/in/rakshit-jain-33ba79181/

image: 43.jpeg
facebook:
mail: mailto:[email protected]
linkedin:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin:
linkedin: https://www.linkedin.com/in/siddarth-venkatraman-59b863157/

image: 31.jpeg
facebook:
mail: mailto:[email protected]
linkedin:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin:
linkedin: https://www.linkedin.com/in/omkar-jadhav-0ab843193/

image: 29.jpeg
facebook:
mail: mailto:[email protected]
linkedin:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin:
linkedin: https://www.linkedin.com/in/manav-sachdeva-497baa190/

image: gaurav.png
facebook: https://www.facebook.com/papadopoulos69
mail: mailto:[email protected]
linkedin: https://www.linkedin.com/in/gaurav-singh-thakhr-74a01a16b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
linkedin: https://www.linkedin.com/in/gaurav-singh-thakhr-74a01a16b
linkedin: https://www.linkedin.com/in/gst101/

nickname: Shivanshu Agarwal
designation: S&A Sensing Head
image: 46.jpeg
facebook: https://w ww.facebook.com/shivanshu.agarwal.965
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
facebook: https://w ww.facebook.com/shivanshu.agarwal.965
facebook: https://www.facebook.com/shivanshu.agarwal.965

@trickarcher
Copy link
Collaborator

I saw this on another college's club website, where they separated the members on the same page using tabs based on the year they were active in the club. We could do that and lazy load the tabs. Here's the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants