Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE CHANGE: Problem in the "Exclusive Deals and Offers" section and the cards as well as title of "The Perfect Travel" section #1900

Closed
4 tasks done
devikaharshey opened this issue Nov 4, 2024 · 3 comments · Fixed by #1907

Comments

@devikaharshey
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the code change

I've came across two issues in which I can contribute:

  1. Exclusive Deals and Offers - There's a problem in spacing between the elements in this section and also when we click on those carousel buttons to navigate through b/w different slides, it isn't very satisfying and the upper section starts having a vibrating effect (shown in the video).

  2. The Perfect Travel - The title text of this section have a small 't' instead of capital 'T' for word 'travel' and also there's a need to fix the padding of text and button inside the cards.
    screenrecord.zip

Proposed solution

  1. Exclusive Deals and Offers - I will make improvements in the spacing between elements of this section and will implement a better carousel.

  2. The Perfect Travel - I will make adjustments in the title text and also the padding b/w the card elements.

Record

  • I agree to follow this project's Code of Conduct
  • I'm a GSSOC'24 contributor
  • I want to work on this issue
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for creating this issue! 🎉 Your issue will soon be reviewed by either the PA or a mentor. Please note that Level 1 is temporary and can be changed during the review. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thanks for creating the issue in BuddyTrail!
Before you start working on your PR, please make sure to:

  • ⭐ Star the repository if you haven't already.
  • Pull the latest changes to avoid any merge conflicts.
  • Attach before & after screenshots in your PR for clarity.
  • Include the issue number in your PR description for better tracking.
    Don't forget to follow @PriyaGhosal – Project Admin – for more updates!

We're excited to see your contribution as part of GSSOC Extended Edition 2024 and Hacktoberfest! 🎉
Happy open-source contributing!

Copy link
Contributor

Hello @devikaharshey! Your issue #1900 has been closed. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant