From ac988f2a248f142e846eadddcfc451345e25fef2 Mon Sep 17 00:00:00 2001 From: rugk Date: Fri, 3 Nov 2023 12:01:24 +0100 Subject: [PATCH] Simplify if condition in build script The of condition likely was wrongly inverted (it said it would run if the branch was _not_ master). Also it's kinda useless anyway, as the trigger definitions above (in `on`) already restrict the branches. --- .github/workflows/build-images.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-images.yml b/.github/workflows/build-images.yml index 5445243..e258513 100644 --- a/.github/workflows/build-images.yml +++ b/.github/workflows/build-images.yml @@ -31,13 +31,13 @@ jobs: install: true - name: Login to DockerHub uses: docker/login-action@v3 - if: (github.ref != 'refs/heads/master' && github.event_name != 'pull_request') || github.event_name == 'schedule' + if: github.event_name != 'pull_request' || github.event_name == 'schedule' with: username: ${{ secrets.DOCKER_USERNAME }} password: ${{ secrets.DOCKER_PASSWORD }} - name: Login to GitHub Container Registry uses: docker/login-action@v3 - if: (github.ref != 'refs/heads/master' && github.event_name != 'pull_request') || github.event_name == 'schedule' + if: github.event_name != 'pull_request' || github.event_name == 'schedule' with: registry: ghcr.io username: privatebin