Skip to content

Commit

Permalink
Simplify if condition in build script
Browse files Browse the repository at this point in the history
The of condition likely was wrongly inverted (it said it would run if the branch was _not_ master).
Also it's kinda useless anyway, as the trigger definitions above (in `on`) already restrict the branches.
  • Loading branch information
rugk authored Nov 3, 2023
1 parent 54165bb commit ac988f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ jobs:
install: true
- name: Login to DockerHub
uses: docker/login-action@v3
if: (github.ref != 'refs/heads/master' && github.event_name != 'pull_request') || github.event_name == 'schedule'
if: github.event_name != 'pull_request' || github.event_name == 'schedule'
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
- name: Login to GitHub Container Registry
uses: docker/login-action@v3
if: (github.ref != 'refs/heads/master' && github.event_name != 'pull_request') || github.event_name == 'schedule'
if: github.event_name != 'pull_request' || github.event_name == 'schedule'
with:
registry: ghcr.io
username: privatebin
Expand Down

0 comments on commit ac988f2

Please sign in to comment.