Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 150 -- Implements read sources under the IO module. #162

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Nov 25, 2024

Description

Sub task of #108 , which is track on branch issue-108

Brings read_sources into the IO namespace.

Issue Number

#150

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

to become specfem::IO::read_sources.

I also removes some unnecessary includes in the main binary for read_mesh that
were omitted in the previous pull request.
@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

@lsawade lsawade merged commit cd5ed77 into issue-108 Nov 25, 2024
3 checks passed
@lsawade lsawade deleted the issue-150 branch November 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants