Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements mesh reading as specfem::IO::read_mesh(...) #149

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Nov 19, 2024

Description

Implements the reading of mesh in form of a read_mesh(filename, mpi) function.

The updates are quite vast since everything had to be moved from the mesh() constructor to all other constructors

Issue Number

Addresses #146 of superissue #108

Closes #146

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • Exisiting unit tests are testing my build, but have added one that just reads the header
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

@buildbot-princeton
Copy link
Collaborator

Can one of the admins verify this patch?

@lsawade
Copy link
Collaborator Author

lsawade commented Nov 20, 2024

Tests pass in serial locally, so crossing my fingers for this one.

@lsawade
Copy link
Collaborator Author

lsawade commented Nov 20, 2024

Oof, I forgot to actually commit the most recent changes...

Recent commit 72a8f2b resolved a swap in the input arguments of read_material_properties as well as assign the tags to mesh.tags which was omitted by accident.

@lsawade
Copy link
Collaborator Author

lsawade commented Nov 20, 2024

If this passes, I'll merge and move on to the sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants