Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data warehouse feedback #21105

Open
11 of 24 tasks
annikaschmid opened this issue Mar 22, 2024 · 3 comments
Open
11 of 24 tasks

Data warehouse feedback #21105

annikaschmid opened this issue Mar 22, 2024 · 3 comments
Assignees

Comments

@annikaschmid
Copy link

annikaschmid commented Mar 22, 2024

Data warehouse

UX / UI

High

Medium

Screenshot 2024-03-22 at 13 05 08
  • (fix(data-warehouse): data warehouse scene ui updates #21189 )Clicking a view at the bottom of the main data warehouse page seems like it doesn’t do anything, because the table schema is outside of the visible area on the screen. I think it would be cool if the page would automatically scroll to the top when a table is selected, or the list of tables is scrollable while the main area of the screen containing the table schema is fixed
  • After creating and saving a join, I can edit it and rename the field name, but clicking the ‘save’ button doesn’t do anything

Low

Screenshot 2024-03-22 at 13 23 32
  • We allow 'view' names with spaces, and then throw a toast error on saving. It would be better if we had inline validation
Screenshot 2024-03-22 at 13 24 35 Screenshot 2024-03-22 at 13 24 47 Screenshot 2024-03-22 at 13 25 34 Screenshot 2024-03-22 at 13 25 47
  • The list of tables when creating a join can get very long and cannot be searched. There is also no visual differentiation between views and tables. (Not sure we need the second if we have the first, it just took me quite long to find the view I wanted to select, which is much easier to spot on the data warehouse first page)
Screenshot 2024-03-22 at 14 40 30

Feature requests

High

Open discussions

HogQL

UX/UI

High

  • Better placeholder (cached data?) when a query is being recalculated and not in edit mode. Right now, the screen is just blank, when a query is loading for 15s you don't even see anything is happening in the background

Medium

  • The error messages are really tricky to interact with, e.g. sometimes there is a 2mm wide red squiggly line, that is really hard to hit with the mouse. Once the popover opens, it says to hit ‘option’ + F8 to view the problem, which doesn’t seem to work for me

Feature requests

High

  • Setting variables in the query, e.g. for date or product
  • Turn cells into links and using the cell content as a variable to link to another table
    -> We use these two features heavily in Metabase, and this is the main thing we are missing to move go/revenue from Metabase to PostHog. e.g. linking stripe_customer_id from this graph to this graph

Medium

  • Error messages don’t reference the line/position an error occurred in (after the query has completed, this works for inline errors), and syntax errors aren’t specifically called out. Some of my errors are the result of a missing ',' and in Metabase, this is much more obvious. In PostHog, it’s quite unclear whether the problem is with the column/data/syntax, when in fact it’s a syntax error

Low

  • Conditional highlighting of cells, e.g. when an invoice isn’t complete yet (Metabase has this)
@annikaschmid
Copy link
Author

@EDsCODE Do you have a GitHub issues label you use for data warehouse? Otherwise I can create a new one, e.g. feature/data-warehouse

@mariusandra
Copy link
Collaborator

We allow 'view' names with spaces, and then throw a toast error on saving. It would be better if we had inline validation

Why not allow spaces everywhere? It looks nicer, and feels more natural to most people. HogQL has two ways you escape spaces in identifiers (double and back quotes), so there's no technical limitation here.

@EDsCODE
Copy link
Member

EDsCODE commented Mar 27, 2024

@annikaschmid is this still a problem? I can't repro it

After creating and saving a join, I can edit it and rename the field name, but clicking the ‘save’ button doesn’t do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants