chore: improve linting (#26)

.github/workflows/rust.yml

@@ -5,7 +5,6 @@ on:
   push:
     branches: [main]
   pull_request:
-    branches: [main]
 
 env:
   CARGO_TERM_COLOR: always
@@ -71,7 +70,7 @@ jobs:
       - name: Run cargo check
         run: cargo check --all-features
 
-  clippy:
+  linting:
     runs-on: depot-ubuntu-22.04-4
 
     steps:
@@ -81,7 +80,7 @@ jobs:
         uses: dtolnay/rust-toolchain@master
         with:
           toolchain: stable
-          components: clippy
+          components: clippy,rustfmt
 
       - uses: actions/cache@v3
         with:
@@ -94,17 +93,18 @@ jobs:
       - name: Run clippy
         run: cargo clippy -- -D warnings
 
-  format:
-    runs-on: depot-ubuntu-22.04-4
+      - name: Check format
+        run: cargo fmt -- --check
 
+  shear:
+    runs-on: depot-ubuntu-22.04-4
     steps:
       - uses: actions/checkout@v3
 
-      - name: Install latest rust
-        uses: dtolnay/rust-toolchain@master
-        with:
-          toolchain: stable
-          components: rustfmt
+      - name: Install cargo-binstall
+        uses: cargo-bins/cargo-binstall@main
 
-      - name: Format
-        run: cargo fmt -- --check
+      - name: Install cargo-shear
+        run: cargo binstall --no-confirm cargo-shear
+
+      - run: cargo shear

Cargo.toml

@@ -11,6 +11,21 @@ members = [
   "hook-worker",
 ]
 
+[workspace.lints.rust]
+# See https://doc.rust-lang.org/stable/rustc/lints/listing/allowed-by-default.html
+unsafe_code = "forbid" # forbid cannot be ignored with an annotation
+unstable_features = "forbid"
+macro_use_extern_crate = "forbid"
+let_underscore_drop = "deny"
+non_ascii_idents = "deny"
+trivial_casts = "deny"
+trivial_numeric_casts = "deny"
+unit_bindings = "deny"
+
+[workspace.lints.clippy]
+# See https://rust-lang.github.io/rust-clippy/, we might want to add more
+enum_glob_use = "deny"
+
 [workspace.dependencies]
 anyhow = "1.0"
 assert-json-diff = "2.0.2"

capture-server/Cargo.toml

@@ -3,6 +3,9 @@ name = "capture-server"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 capture = { path = "../capture" }
 envconfig = { workspace = true }

capture/Cargo.toml

@@ -3,7 +3,8 @@ name = "capture"
 version = "0.1.0"
 edition = "2021"
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]
+workspace = true
 
 [dependencies]
 anyhow = { workspace = true }

capture/src/sinks/kafka.rs

@@ -118,10 +118,10 @@ impl KafkaSink {
             client_config.create_with_context(KafkaContext { liveness })?;
 
         // Ping the cluster to make sure we can reach brokers, fail after 10 seconds
-        _ = producer.client().fetch_metadata(
+        drop(producer.client().fetch_metadata(
             Some("__consumer_offsets"),
             Timeout::After(Duration::new(10, 0)),
-        )?;
+        )?);
         info!("connected to Kafka brokers");
 
         Ok(KafkaSink {

common/health/Cargo.toml

@@ -3,7 +3,8 @@ name = "health"
 version = "0.1.0"
 edition = "2021"
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]
+workspace = true
 
 [dependencies]
 axum = { workspace = true }

hook-api/Cargo.toml

@@ -3,7 +3,8 @@ name = "hook-api"
 version = "0.1.0"
 edition = "2021"
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]
+workspace = true
 
 [dependencies]
 axum = { workspace = true }

hook-common/Cargo.toml

@@ -3,7 +3,8 @@ name = "hook-common"
 version = "0.1.0"
 edition = "2021"
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]
+workspace = true
 
 [dependencies]
 async-trait = { workspace = true }

hook-common/src/pgqueue.rs

@@ -827,14 +827,15 @@ mod tests {
 
         let retry_interval = retry_policy.retry_interval(job.job.attempt as u32, None);
         let retry_queue = retry_policy.retry_queue(&job.job.queue).to_owned();
-        let _ = job
-            .retry(
+        drop(
+            job.retry(
                 "a very reasonable failure reason",
                 retry_interval,
                 &retry_queue,
             )
             .await
-            .expect("failed to retry job");
+            .expect("failed to retry job"),
+        );
         batch.commit().await.expect("failed to commit transaction");
 
         let retried_job: PgTransactionJob<JobParameters, JobMetadata> = queue
@@ -883,14 +884,15 @@ mod tests {
 
         let retry_interval = retry_policy.retry_interval(job.job.attempt as u32, None);
         let retry_queue = retry_policy.retry_queue(&job.job.queue).to_owned();
-        let _ = job
-            .retry(
+        drop(
+            job.retry(
                 "a very reasonable failure reason",
                 retry_interval,
                 &retry_queue,
             )
             .await
-            .expect("failed to retry job");
+            .expect("failed to retry job"),
+        );
         batch.commit().await.expect("failed to commit transaction");
 
         let retried_job_not_found: Option<PgTransactionBatch<JobParameters, JobMetadata>> = queue

hook-janitor/Cargo.toml

@@ -3,7 +3,8 @@ name = "hook-janitor"
 version = "0.1.0"
 edition = "2021"
 
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+[lints]
+workspace = true
 
 [dependencies]
 async-trait = { workspace = true }

hook-worker/Cargo.toml

@@ -3,6 +3,9 @@ name = "hook-worker"
 version = "0.1.0"
 edition = "2021"
 
+[lints]
+workspace = true
+
 [dependencies]
 axum = { workspace = true }
 chrono = { workspace = true }