Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations #36

Open
Plushtoast opened this issue Sep 20, 2021 · 9 comments
Open

Translations #36

Plushtoast opened this issue Sep 20, 2021 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@Plushtoast
Copy link
Owner

Plushtoast commented Sep 20, 2021

Roll20 translation has been changed. Translations can not be added via merge requests anymore.
Instead they have to be created via CrowdIn

If you want to contribute go to
https://crowdin.com/project/roll20-character-sheets

Select the language you want to update.
Find the character sheet ** Das Schwarze Auge (TDE) 5 OFFICIAL by Ulisses ** and start translating.

You can read more about the process here:
https://help.roll20.net/hc/en-us/articles/360057432414-How-to-Translate-Content-on-Crowdin#-how-do-i-use-crowdin-to-actually-translate-the-content--0-1

We have requested and promised access to submit entire files for translation to Roll20 but this is not available yet.

@Plushtoast Plushtoast added the help wanted Extra attention is needed label Sep 20, 2021
@Plushtoast Plushtoast pinned this issue Sep 20, 2021
@dyvim
Copy link

dyvim commented Oct 25, 2021

hello @Plushtoast

will you correct the translation files (aka add the missing keys and delete the obsolete) at the release? or generate new ones?
normally in roll20 the translations are done via crowdin but if there is missing keys, the corresponding words won't be translatable.
the translation files in the translation directory that can be seen in your project are not correct it seems (see error.md)
as i've already translated in french the 2 DSA5 sheets in roll20, i'll probably use crowdin to translate the new official one as soon as it will be avalaible.

BRgds

@Plushtoast
Copy link
Owner Author

Yeah, don't start translating yet. I am still learning about roll20 and didn't know about crowdin until recently

@dyvim
Copy link

dyvim commented Oct 25, 2021

you can submit translation files when you create the sheet (at the first commit) but after that the translation has to be done via crowdin. to get an access to crowdin, you have to send a mail at [email protected]
all the translation files have to contain all the data-i18n keys, so the missing keys have to be added in each file. they can not be added via crowdin
at the moment, for what i see in your pull request, there is only one translation file (the translation.json) and the language is in german. it's ok like that but the english (and french) translations will have to be done via crowdin.

as the translation has not be really too much modified since the tsa edition sheet, it will be quick to translate (crowdin will suggest us the previous translations). if it is quicker for you, i can manage the english translation as well as the french one (assuming i'll only copy paste the old translation). (i have already a crowdin access)
if you can just provide me the official translation for the few new keys that you have added it'll be OK.

oh and by the way, nobody can start translating before your pull request is commited (and at the moment the pull request doesn't seem to be validated)

BRgds

@Plushtoast
Copy link
Owner Author

Thanks for your clarification. The English translation is already finished and will be maintained officially.
We'll wait for roll20 approval before we take any other additional steps

@dyvim
Copy link

dyvim commented Oct 26, 2021

if you check the pull request for Hexxen 1733 (an other Ulisses game) there's a note that details an other way to release translation files
Roll20/roll20-character-sheets#9482

by Nmbradley

Would it be possible for you to remove the translation files (other than translations.json) from this Pull Request?
These files are included from another service (CrowdIn), and can't be added directly to the github.
If you send me a separate link to the translation files, I can manually create them in that service.
Thanks!

and your pull request is still not validated. maybe you should replay the checks

@dyvim
Copy link

dyvim commented Nov 4, 2021

for information :

  • french translation is ok at 100% (old and new keys)
  • dutch is ok at 98% (only the new keys are missing a translation)
  • italian is ok at 95% (i've get back all the old translations from the tsa edition but the translations were not complete and of course the new keys are missing a translation)

@Kesatjow
Copy link

Any updates regarding english translation?

@dyvim
Copy link

dyvim commented Mar 10, 2022 via email

@Plushtoast
Copy link
Owner Author

If you want to you can also create the polish translation yourself. See the guide above. Officially supported will only be German and English, while french and Italian are inofficially maintained (by e.g. dyvim)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: No status
Development

No branches or pull requests

3 participants