Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fruit initiation stage #75

Open
edenny opened this issue Sep 25, 2023 · 5 comments
Open

fruit initiation stage #75

edenny opened this issue Sep 25, 2023 · 5 comments

Comments

@edenny
Copy link
Collaborator

edenny commented Sep 25, 2023

The Env Study Centre dataset from India includes a phase for fruit bud/fruit initiation. He described it to me as "just after the fall of petals small fruit bud appears after the falling of flower, immature fruit means not yet ripened the stage between fruit bud and ripened fruit". It is followed by an immature fruit stage.

Should we add something for this?

@ClaudHGE
Copy link

Hi @edenny I have noticed that as well. I'm currently editing a branch to submit a pull request for that issue.

@ramonawalls
Copy link
Contributor

@ClaudHGE, could you please add your justification for including a new class here?

@ClaudHGE
Copy link

🚧 working on it!

@edenny
Copy link
Collaborator Author

edenny commented Nov 13, 2023

This sounds reasonable to me and works for the datasets I have seen so far.

One point of clarification though @ClaudHGE ....where you write:

"Now, when a fruit is in the 'fruit unripe stage', an occurrent entity, what we can actually observe is the 'unripe fruit' (PPO:0001045), a continuant entity, and the respective phenological trait would be ‘ripe fruit presence’ (PPO:0002047) and we could either annotate ‘ripe fruits present’ (PPO:0002345) or 1 'ripe fruit'. (Please correct me if I am wrong). "

I think you meant to say the respective phenological trait would be ‘unripe fruit presence’ , correct?

@ClaudHGE
Copy link

You are absolutely right! I've edited the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants