JavaScript hygiene automation

[simsong]

Simson has no idea how to do this.
- [ ] Create unit tests for all JavaScript. Issue moved to #354

• Add JavaScript lint to the Makefile
• Add JavaScript Jest testing to GitHub actions.
• Add JavaScript lint to GItHub Actions

[simsong]

@sbarber2 - How does this strike you:

• Jest for unit tests
• Vite to support JavaScript development

And eventually:

• Webpack to bundle JavaScript.

[sbarber2]

I'm unclear on the precise relationship of Vite (a build tool) and Webpack (a bundler) to the stated goal of this issue of creating unit tests. Seems like this should be 3 enhancement separate Issues.

Also, this issue is somewhat duplicative of #354 and #422

[sbarber2]

Add JavaScript lint to the pytest

What does this mean? Does pytest here mean something like "the pytest (or pytest-app-framework) target of the top-level Makefile"? Or maybe this means just to Do The Right Thing to automate running all our regression tests, regardless of language of origin?

[sbarber2]

OK, am rescoping this Issue. JavaScript Jest-based unit tests covered in #354.
Other JavaScript hygiene automation is in scope; see Issue description above.
Moving the Vite and Webpack discussions to, well, discussions #597 and #598 , respectively.

[sbarber2]

I am reluctant to add eslint (JavaScript) lint to our continuous-integration.yml or as a gate for commits or PR merges until we have good test coverage for our existing JavaScript modules (#354). That is, fixing lint violations changes code and thus good practice suggests doing regression testing that we don't have yet. And at that point, we may as well fix all the lint violations in one go so as to take the hit of a huge PR diff just once. My guess is that we won't get to this for Dec2024, but maybe the next one.