Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deparse doesn't handle classes #22777

Open
tonycoz opened this issue Nov 25, 2024 · 0 comments
Open

deparse doesn't handle classes #22777

tonycoz opened this issue Nov 25, 2024 · 0 comments

Comments

@tonycoz
Copy link
Contributor

tonycoz commented Nov 25, 2024

Module:

Trying to deparse a method of a class produces a message and incorrect code:

$ ./perl -Ilib -Mfeature=class -MO=Deparse -e 'class A { method b {} }'
class is experimental at -e line 1.
method is experimental at -e line 1.
unexpected OP_METHSTART at lib/B/Deparse.pm line 1677.
use feature 'class';
{
    ();
    package A;
    sub b : method {
        XXX;
        ();
    }
}
-e syntax OK

fields are also not deparsed:

$ ./perl -Ilib -Mfeature=class -MO=Deparse -e 'class A { field $x; method x { $x } }'
class is experimental at -e line 1.
field is experimental at -e line 1.
method is experimental at -e line 1.
unexpected OP_METHSTART at lib/B/Deparse.pm line 1677.
use feature 'class';
{
    package A;
    ;
    sub x : method {
        XXX;
        $x;
    }
}
-e syntax OK

Steps to Reproduce

See above.

Expected behavior

Deparse handles the OP_METHSTART and emits the field declarations.

Perl configuration

Summary of my perl5 (revision 5 version 41 subversion 7) configuration:
  Commit id: f254d774f8489de819d97ce662af2dbe3eb9f12b
  Platform:
    osname=linux
    osvers=6.1.0-25-amd64
    archname=x86_64-linux-thread-multi
    uname='linux venus 6.1.0-25-amd64 #1 smp preempt_dynamic debian 6.1.106-3 (2024-08-26) x86_64 gnulinux '
    config_args='-des -Dusedevel -Dusethreads'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2'
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='12.2.0'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/x86_64-linux-gnu /usr/lib /usr/lib64
    libs=-lpthread -lgdbm -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
    libc=/lib/x86_64-linux-gnu/libc.so.6
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.36'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


Characteristics of this binary (from libperl): 
  Compile-time options:
    HAS_LONG_DOUBLE
    HAS_STRTOLD
    HAS_TIMES
    MULTIPLICITY
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_HASH_FUNC_SIPHASH13
    PERL_HASH_USE_SBOX32
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_DEVEL
    PERL_USE_SAFE_PUTENV
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_ITHREADS
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
    USE_REENTRANT_API
    USE_THREAD_SAFE_LOCALE
  Built under linux
  Compiled at Nov 25 2024 10:56:52
  %ENV:
    PERLBREW_BASHRC_VERSION="0.43"
    PERLBREW_HOME="/home/tony/.perlbrew"
    PERLBREW_MANPATH=""
    PERLBREW_PATH="/home/tony/perl5/perlbrew/bin"
    PERLBREW_ROOT="/home/tony/perl5/perlbrew"
    PERLBREW_VERSION="0.67"
  @INC:
    lib
    /usr/local/lib/perl5/site_perl/5.41.7/x86_64-linux-thread-multi
    /usr/local/lib/perl5/site_perl/5.41.7
    /usr/local/lib/perl5/5.41.7/x86_64-linux-thread-multi
    /usr/local/lib/perl5/5.41.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant