Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBI] Enable the display for external and internal IPs in the endpoints #224

Closed
4 of 7 tasks
cjlapao opened this issue Oct 30, 2024 · 0 comments · Fixed by #225 or #235
Closed
4 of 7 tasks

[PBI] Enable the display for external and internal IPs in the endpoints #224

cjlapao opened this issue Oct 30, 2024 · 0 comments · Fixed by #225 or #235
Assignees
Labels
pbi Product Backlog Item
Milestone

Comments

@cjlapao
Copy link
Collaborator

cjlapao commented Oct 30, 2024

Description

We want to be able to display the internal and external ips for each VM, these will be displayed in different endpoints that we have.

The endpoints that need to be updated are the following.

/api/v1/config/hardware
/api/v1/machines
/api/v1/machines/{{MACHINE-ID}}
/api/v1/orchestrator/hosts/{{HOST-ID}}
/api/v1/orchestrator/machines
/api/v1/orchestrator/machines/{{MACHINE-ID}}

User Story

  • As a user when going to the endpoints for the machines I can see the internal and external IP
  • As a user when going to the orchestrator endpoints I can see the external IP for those hosts

Acceptance Criteria

  • All endpoints that are listed on top do display the correct ips

Definition of Done

  • Code implemented following best practices.
  • Unit tests written and passing.
  • Code reviewed and approved.
  • Merged into the main branch.
  • Documentation updated (if applicable).
  • Deployed to staging/production environment.

Assumptions and Constraints

No response

Assumptions and Constraints

No response

Additional Notes

No response

@cjlapao cjlapao added triage Selected for triage pbi Product Backlog Item labels Oct 30, 2024
@cjlapao cjlapao self-assigned this Oct 30, 2024
@cjlapao cjlapao added this to the 0.9.10 milestone Oct 30, 2024
@cjlapao cjlapao removed the triage Selected for triage label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pbi Product Backlog Item
Projects
None yet
1 participant