We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
result["before"] includes newly added items when updating a list type param. Issue seen on panos_security_rule but possibly exists on others as well.
result["before"]
panos_security_rule
Consider the following scenario:
Existing security rule only have "192.168.8.0/24" in source_ip.
Following request is made to add additional address to the list of source_ip.
- name: "merged state update" paloaltonetworks.panos.panos_security_rule: provider: "{{ device }}" state: merged device_group: "lab1-ha-dg" rulebase: "post-rulebase" rule_name: "rule-with-defaults" source_ip: ["10.0.0.0/8"] source_zone: ["private"]
In result["before"] it looks like following, whereas it looks correct in result["diff"]["before"] with "192.168.8.0/24" only;
result["diff"]["before"]
"source_ip": [ "192.168.8.0/24", "10.0.0.0/8" ],
result["before"] should return existing configuration, not merged configuration for list type params.
It looks like we need a fix in describe() method to return with a deep-copied list as nested list in the object might be the issue..
describe()
The text was updated successfully, but these errors were encountered:
alperenkose
No branches or pull requests
Describe the bug
result["before"]
includes newly added items when updating a list type param. Issue seen onpanos_security_rule
but possibly exists on others as well.Consider the following scenario:
Existing security rule only have "192.168.8.0/24" in source_ip.
Following request is made to add additional address to the list of source_ip.
In
result["before"]
it looks like following, whereas it looks correct inresult["diff"]["before"]
with "192.168.8.0/24" only;Expected behavior
result["before"]
should return existing configuration, not merged configuration for list type params.Possible solution
It looks like we need a fix in
describe()
method to return with a deep-copied list as nested list in the object might be the issue..The text was updated successfully, but these errors were encountered: