lzj-rfc

[ZhijunLStudio]

提交rfc文件，请查阅

[paddle-bot]

Thanks for your contribution!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

zhijun.li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[lyuwenyu]

收到； 接下来可以继续完善代码 提交正式的PR 有问题随时沟通

[lyuwenyu]

代码从使用的角度没问题；但是

1. 如果要合入的话 代码结构参考这里的写法
   https://github.com/PaddlePaddle/PaddleMIX/tree/develop/paddlemix/datacopilot/ops

2. 另外可以把逻辑拆分一下，函数参数是item

# 逻辑
def func(item): ...

# 使用
newdataset = dataset.map(func)

[ZhijunLStudio]

收到，谢谢老师

…

------------------ Original ------------------ From: lyuwenyu ***@***.***> Date: Wed,Nov 13,2024 5:29 PM To: PaddlePaddle/PaddleMIX ***@***.***> Cc: ZhijunLStudio ***@***.***>, Author ***@***.***> Subject: Re: [PaddlePaddle/PaddleMIX] lzj-rfc (PR #810) 代码从使用的角度没问题； 但是如果要合入的话 代码结构参考这里的写法 https://github.com/PaddlePaddle/PaddleMIX/tree/develop/paddlemix/datacopilot/ops 另外可以把逻辑拆分一下，函数参数是其中一个item # 逻辑 def func(item): ... # 使用 newdataset = dataset.map(func) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>