Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move go/updater to PaddlePaddle/edl/pkg/updater #643

Open
helinwang opened this issue Mar 13, 2018 · 3 comments
Open

Move go/updater to PaddlePaddle/edl/pkg/updater #643

helinwang opened this issue Mar 13, 2018 · 3 comments
Assignees

Comments

@helinwang
Copy link
Collaborator

Hi @qizheng09,

Could you please remove go/updater from PaddlePaddle/cloud and send a PR to move it to PaddlePaddle/edl/pkg/updater?

Sorry I could have done it when pushing the PaddlePaddle/cloud git history to PaddlePaddle/edl, bit at that time I was not aware that go/updater is part of EDL when moving EDL code to PaddlePaddle/edl (related issue).

I could do it for you but the commit author will be me, but I think it's better for you to be the commit author because it's your contribution to PaddlePaddle, I don't want to take the credit from you.

Btw, feel free to wait for this PR gets merged and then do it.

Thank you!

@qizheng09
Copy link
Collaborator

No problem

@helinwang
Copy link
Collaborator Author

@qizheng09 please send the PR to develop_CRD branch, it will replace the master branch once CRD development is finished. Thank you very much!

@qizheng09
Copy link
Collaborator

@helinwang Okay~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants