Skip to content
This repository has been archived by the owner on Aug 27, 2021. It is now read-only.

All Day events not working properly #85

Open
cpw7922 opened this issue Sep 17, 2020 · 2 comments · May be fixed by #115
Open

All Day events not working properly #85

cpw7922 opened this issue Sep 17, 2020 · 2 comments · May be fixed by #115

Comments

@cpw7922
Copy link

cpw7922 commented Sep 17, 2020

My all day events are showing up as 8pm-8pm instead of All Day events. Non-All Day events show up just fine. Not sure if all_day or is_all_day is being looked at

v0.115 Calendar Card
image

Custom Calendar Card
image

message: Test
all_day: false
start_time: '2020-09-16 20:00:00'
end_time: '2020-09-17 20:00:00'
location:
  displayName: ''
  locationType: default
  uniqueIdType: unknown
  address: {}
  coordinates: {}
description: ''
offset_reached: false
data:
  - summary: Test
    description: ''
    location: ''
    categories: []
    sensitivity: Normal
    show_as: Free
    is_all_day: true
    attendees: []
    start: '2020-09-17T00:00:00+00:00'
    end: '2020-09-18T00:00:00+00:00'
@mshish
Copy link

mshish commented Oct 6, 2020

I have the same issue. My all day events are shifted -4 hours off of midnight (which corresponds to my time zone). HA and my docker container have the correct timezone set and all appointments that are not all day appear with the correct start/end times in the calendar. I am happy to try and debug/track this bug down, but I'm new to HA plugins, so any pointers on where to look would be appreciated.

@boerjb
Copy link

boerjb commented Dec 14, 2020

Same here. "is_all_day: true in the payload but the attribute "all_day" is set to false. On top the entry shows up on two days as the day is shifted by one hour:
message: Birthday
all_day: false
start_time: '2020-12-14 01:00:00'
end_time: '2020-12-15 01:00:00'
location:
displayName: ''
locationType: default
uniqueIdType: unknown
address: {}
coordinates: {}
description: ''
offset_reached: false
data:

  • summary: Birthday
    description: ''
    location: ''
    categories: []
    sensitivity: Normal
    show_as: Busy
    is_all_day: true
    attendees: []
    start: '2020-12-14T01:00:00+01:00'
    end: '2020-12-15T01:00:00+01:00'

mshish added a commit to mshish/O365-HomeAssistant that referenced this issue May 22, 2021
Attempts to fix PTST#85
Two changes:
1. Bring in fix from home-assistant/core#48642 which doesn't make much of a difference here (branch doesn't appear to get hit with all day events).
1. Fix the timezone shift for all day events. I'm not sure this is in the right place since it appears o365 is returning the event as if it were on GMT (but it's not). This may only work if the all day event was actually in the local timezone.
@mshish mshish linked a pull request May 22, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants