Fixing some light/dark mode issues lying around the site. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eti7075
commented
Jun 12, 2024
eti7075
commented
- Added a variable background color for the theme selector icon to match the navbar color scheme in dark mode.
- Changed the gutter color and scroller color for the scroll bar in the inspector panel table during dark mode usage.
- Updated the :root background color scheme to be more consistent. Now, regardless of the user's browser dark/light preference, the site root will have the same background, resulting in a consistent map shade.
3 tasks
eti7075
commented
Jun 12, 2024
| @@ -61,4 +61,7 @@ | |||
|
|
|||
| box-shadow: 0 2px 4px black; | |||
| color: white; | |||
|
|
|||
| scrollbar-color: var(--ifm-color-secondary-darkest) | |||
There was a problem hiding this comment.
Only substantive change. This lies within the .theme-dark .inspector-panel property definition. Other changes are formatting
eti7075
commented
Jun 12, 2024
| @@ -23,7 +23,11 @@ function InspectorPanel({ entity }) { | |||
| </tbody> | |||
| </table> | |||
| <p> | |||
| <a href="https://docs.overturemaps.org/schema/" target="_blank" rel="noreferrer noopener"> | |||
| <a | |||
| href="https://docs.overturemaps.org/schema/" | |||
eti7075
commented
Jun 12, 2024
| @@ -327,7 +325,10 @@ export default function Map({ mode, mapEntity, setMapEntity, setZoom }) { | |||
| <InspectorPanel entity={mapEntity} /> | |||
| )} | |||
|
|
|||
| <ThemeSelector visibleThemes={setVisibleThemes}></ThemeSelector> | |||
| <ThemeSelector | |||
| mode={mode} | |||
There was a problem hiding this comment.
Adds mode state to theme selector, also includes formatting changes
eti7075
commented
Jun 12, 2024
| } | ||
|
|
||
| svg.icon-layers-dark { |
There was a problem hiding this comment.
only substantive change, adding a adaptive background coloring and border radius to match the light mode shape. All other changes in file are formatting.
eti7075
commented
Jun 12, 2024
| @@ -24,7 +24,11 @@ function ThemeSelector({ visibleThemes }) { | |||
| return ( | |||
| <div className="dropdown dropdown--hoverable theme-selector tour-layers"> | |||
| <div className="layer-control"> | |||
| <LayerIcon /> | |||
| <LayerIcon | |||
| className={`icon-layers ${ | |||
There was a problem hiding this comment.
adding classname to icon for css
eti7075
commented
Jun 12, 2024
| @@ -92,3 +92,9 @@ div.theme-light { | |||
| color: #213547; | |||
| background-color: #ffffff; | |||
| } | |||
|
|
|||
| @media (prefers-color-scheme: dark) { | |||
There was a problem hiding this comment.
updating the background during dark mode browser usage
Bonkles
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.