Vote delegation setting #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #225
There are two corner cases, that should be handled the same in all services.
What should happen, when
meeting/users_forbid_delegator_to_voteis set totrue, the request user has delegated his vote, he votes for himself butmeeting/users_enable_vote_delegationsis set tofalse. This could happen, if a meeting admin decides later to deactivate vote-delegation. Should the user be allowed to vote for himself in this case? In This PR, he is allowed to vote for himself.What should happen, if for any reason a user delegates his vote to himself (is this even possible in the backend?). Should he be allowed to vote for himself when
meeting/users_forbid_delegator_to_voteistrue? In this PR, he is not allowed to vote for himself, since this is, what the setting is saying. Does the client allow to send a vote request in this case?