Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename write_action_worker etc. #258

Closed
r-peschke opened this issue Sep 22, 2023 · 2 comments · Fixed by #259
Closed

rename write_action_worker etc. #258

r-peschke opened this issue Sep 22, 2023 · 2 comments · Fixed by #259
Assignees
@r-peschke
Labels
enhancement General enhancement which is neither bug nor feature
Milestone
4.1

Comments

@r-peschke
Copy link
Member

r-peschke commented Sep 22, 2023 •
edited
Loading

The route for the action_worker-collection was extended to write also the import_preview, which should be written and physically deleted identical.
The name should be changed to write_without_events
@r-peschke r-peschke added the enhancement General enhancement which is neither bug nor feature label Sep 22, 2023
@r-peschke r-peschke added this to the 4.1 milestone Sep 22, 2023
@r-peschke r-peschke self-assigned this Sep 22, 2023
@r-peschke r-peschke linked a pull request Sep 22, 2023 that will close this issue
Open action_worker route also for collection import_preview #259
Merged
2 tasks
@jsangmeister
Copy link
Contributor

How about something like write_without_events or write_models? This would free the naming from the actual usage and only describe what is actually done.

@jsangmeister jsangmeister mentioned this issue Sep 26, 2023
Merged
2 tasks
@jsangmeister
Copy link
Contributor

Chosen name: write_without_events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-peschke r-peschke

Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Open action_worker route also for collection import_preview r-peschke/openslides-datastore-service
2 participants
@r-peschke @jsangmeister