Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate get_forwarding_meetings and motion.create_forwarded #3067

Open
luisa-beerboom opened this issue Dec 4, 2023 · 3 comments
Open
Labels
bug low needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Milestone

Comments

@luisa-beerboom
Copy link
Member

See OpenSlides/openslides-backend#2003 and OpenSlides/openslides-backend#2009

According to tracebacks in the logs it seems these two processes were called with insufficient payloads.

The get_forwarding_meetings presenter was seemingly called with a payload that didn't contain a meeting_id
The motion.create_forwarded action was seemingly called without a meeting_id and, another time, without an origin_id.
The latter action also has other required fields, but they would not have caused the same error in the backend.

Please take a good look at these actions in particular and check if the client can actually be made to send these types of payloads and, if yes, fix that

@luisa-beerboom luisa-beerboom added bug low needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time labels Dec 4, 2023
@luisa-beerboom luisa-beerboom added this to the 4.2 milestone Dec 4, 2023
@reiterl reiterl self-assigned this Feb 9, 2024
@reiterl
Copy link
Member

reiterl commented Feb 9, 2024

The get_forwarding_meetings presenter is called in the motion-forward-dialog. The activeMeeting.meetingId could be null in some cases, so add a check here.

@reiterl
Copy link
Member

reiterl commented Feb 9, 2024

I looked at the MotionRepositoryService.createForwarded() function. I don't find the reason, why meeting_id or origin_id could be null or undefined. Mmh, no idea. This seems to be the only function in which the CREATE_FORWARDED action is used.

@rrenkert
Copy link
Member

#3527 and #3529 are features in same scope. Can we have this one in mind when working on them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug low needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Projects
None yet
Development

No branches or pull requests

3 participants