Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new saml meeting mapping #2722

Merged
merged 17 commits into from
Nov 25, 2024
Merged

new saml meeting mapping #2722

merged 17 commits into from
Nov 25, 2024

Conversation

hjanott
Copy link
Member

@hjanott hjanott commented Nov 8, 2024 •
edited
Loading

Closes #2674

@hjanott hjanott added the feature label Nov 8, 2024
@hjanott hjanott added this to the 4.2 milestone Nov 8, 2024
@hjanott hjanott self-assigned this Nov 8, 2024
luisa-beerboom
luisa-beerboom reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not looked at the overall function yet, since this isn't even finished, but there are some things I found

openslides_backend/action/actions/user/save_saml_account.py Outdated Show resolved Hide resolved
openslides_backend/action/actions/user/save_saml_account.py Outdated Show resolved Hide resolved
openslides_backend/action/actions/user/save_saml_account.py Outdated Show resolved Hide resolved
tests/system/action/user/test_save_saml_account.py Outdated Show resolved Hide resolved
tests/system/action/user/test_save_saml_account.py Outdated Show resolved Hide resolved
@hjanott hjanott assigned luisa-beerboom and unassigned hjanott Nov 12, 2024
@hjanott hjanott marked this pull request as ready for review November 12, 2024 16:50
luisa-beerboom
luisa-beerboom approved these changes Nov 13, 2024
View reviewed changes
docs/actions/user.save_saml_account.md
Comment on lines +48 to +49
- If no group exists for a meeting and no default is given, the meetings default group is used. (Logged as warning)
- If a structure level does not exist, it is created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're matching groups via external_id, you should explain that here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hjanott hjanott added the waiting Waiting for some other PR/feature; more details in comments label Nov 15, 2024
@luisa-beerboom luisa-beerboom removed their assignment Nov 15, 2024
emanuelschuetze
emanuelschuetze approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@Elblinator Elblinator mentioned this pull request Nov 22, 2024
Closed
@reiterl reiterl mentioned this pull request Nov 22, 2024
Merged
@rrenkert rrenkert removed the waiting Waiting for some other PR/feature; more details in comments label Nov 25, 2024
@hjanott hjanott enabled auto-merge (squash) November 25, 2024 14:54
@hjanott hjanott merged commit deac9e1 into OpenSlides:main Nov 25, 2024
5 checks passed
@rrenkert rrenkert mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisa-beerboom luisa-beerboom luisa-beerboom approved these changes

@emanuelschuetze emanuelschuetze emanuelschuetze approved these changes

Assignees

@hjanott hjanott

Labels
feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Attribute mapper for meeting-user from SAML
4 participants
@hjanott @emanuelschuetze @luisa-beerboom @rrenkert