Prevent vote weight of 0 #1938
Merged
Prevent vote weight of 0 #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-peschke
requested changes
Nov 2, 2023
| @@ -216,6 +216,8 @@ def get_schema(self) -> Schema: | |||
| schema = self.extend_schema(super().get_schema(), **decimal_schema) | |||
| if not self.required: | |||
| schema["type"] = ["string", "null"] | |||
| # remove minimum since it is checked in the validate method | |||
| schema.pop("minimum", None) | |||
There was a problem hiding this comment.
IMO the minimum value is added to be checked!??? Why this should be removed?
Maybe the check has to be suppressed in case of a non required decimal. But not required with minimum value seems curious IMO.
There was a problem hiding this comment.
As the comment states, the minimum is checked manually in the validate method right below that. jsonschema is not capable of handling decimals as string, therefore this has to be done manually and the minimum constraint has to be removed from the schema.
r-peschke
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1926
also some cleanup of the models validator