Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validate_entry on user json_uploads #2445

Open
luisa-beerboom opened this issue May 27, 2024 · 1 comment
Open

Refactor validate_entry on user json_uploads #2445

luisa-beerboom opened this issue May 27, 2024 · 1 comment
Labels
Milestone

Comments

@luisa-beerboom
Copy link
Member

In user/base_json_upload.py
The method is way too long and hard to understand.
It should hopefully be possible to make it shorter/more readable/more efficient.

Maybe consider doing the same for other json_uploads

@luisa-beerboom luisa-beerboom added this to the 4.2 milestone May 27, 2024
@luisa-beerboom luisa-beerboom self-assigned this Sep 20, 2024
@luisa-beerboom luisa-beerboom removed their assignment Oct 28, 2024
@luisa-beerboom
Copy link
Member Author

In accordance with this comment, we should probably wait for the new concept before doing the cleanup, because @MSoeb seems to imply that a complete overhaul of the user import code may be necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant