Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError in get_forwarding_meetings presenter #2003

Closed
jsangmeister opened this issue Nov 21, 2023 · 3 comments · Fixed by #2038
Closed

Fix KeyError in get_forwarding_meetings presenter #2003

jsangmeister opened this issue Nov 21, 2023 · 3 comments · Fixed by #2038
Assignees
Labels
Milestone

Comments

@jsangmeister
Copy link
Contributor

This traceback occured and should be fixed:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/gthread.py", line 282, in handle
    keepalive = self.handle_request(req, conn)
  File "/usr/local/lib/python3.10/site-packages/gunicorn/workers/gthread.py", line 334, in handle_request
    respiter = self.wsgi(environ, resp.start_response)
  File "/app/openslides_backend/http/application.py", line 103, in __call__
    return self.wsgi_application(environ, start_response)
  File "/app/openslides_backend/http/application.py", line 93, in wsgi_application
    response = self.dispatch_request(request)
  File "/app/openslides_backend/http/application.py", line 44, in dispatch_request
    response_body, access_token = view_instance.dispatch(request)
  File "/app/openslides_backend/http/views/base_view.py", line 117, in dispatch
    return func(request)
  File "/app/openslides_backend/http/views/presenter_view.py", line 30, in presenter_route
    presenter_response, access_token = handler.handle_request(request)
  File "/app/openslides_backend/presenter/presenter.py", line 77, in handle_request
    response, access_token = self.parse_presenters(request)
  File "/app/openslides_backend/presenter/presenter.py", line 134, in parse_presenters
    result = presenter_instance.get_result()
  File "/app/openslides_backend/presenter/get_forwarding_meetings.py", line 40, in get_result
    self.data["meeting_id"],
KeyError: 'meeting_id'
@luisa-beerboom
Copy link
Member

luisa-beerboom commented Dec 4, 2023

Seems someone sent an empty payload, we should probably look to see if there is a bug in the client that may do this, for now, I've ensured with a PR that the schema validator knows the meeting_id field to be required

@luisa-beerboom
Copy link
Member

I suppose I'll be creating an investigation issue for this and #2009 in the client repo

@luisa-beerboom
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants