-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't delete past speakers upon user.delete #1917
Comments
The deletion rules are set in the models.yml, in the head of that file they are explained.
see above, I don't think it is used regularly. But this is easier to implement, although there will be a performance penalty on user.update, where the removal from groups is made, |
After discussion (@rrenkert, @luisa-beerboom @m-schieder @r-peschke ) we decided to follow the proposal. |
For background see OpenSlides/openslides-client#2639
Upon deletion of a user, any speaker instance related to him is currently also deleted.
This is fine for speakers who are still in the waiting list, but those who are either currently speaking (i.e.
start_time
is defined) or finished (i.e.end_time
is defined) should not be deleted for the sake of keeping a coherent protocol.So:
If a user is deleted:
start_time
orend_time
should be deleted.start_time
orend_time
should have the user removed, but should not be deleted.Also:
While testing we've noticed that removing a user from a meeting via removal from the relevant groups doesn't remove him from the meetings speaker lists either.
This should show a similar behaviour to the deletion:
If a user is removed from a meeting:
start_time
orend_time
should be deleted.start_time
orend_time
should not be deleted. In this case the user should NOT be removed from the speaker though.The text was updated successfully, but these errors were encountered: