Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace get_all by filter in migrations #1906

Closed
r-peschke opened this issue Sep 14, 2023 · 3 comments
Closed

Replace get_all by filter in migrations #1906

r-peschke opened this issue Sep 14, 2023 · 3 comments
Assignees
@r-peschke
Labels
performance
Milestone
4.1

Comments

@r-peschke
Copy link
Member

No description provided.

@r-peschke r-peschke added this to the 4.1 milestone Sep 14, 2023
@r-peschke r-peschke self-assigned this Sep 14, 2023
@rrenkert
Copy link
Member

As seen in #1910 that's not always a good idea. Filter also returns deleted models which causes problems in update events.

@jsangmeister
Copy link
Contributor

This can be prevented by using And(FilterOperator("meta_deleted", "=", False), ...). Missed this during the review.

@rrenkert
Copy link
Member

This is implemented in #1910.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-peschke r-peschke

Labels
performance
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
3 participants
@rrenkert @r-peschke @jsangmeister