Make meeting_user actions backend internal

[jsangmeister]

The meeting user actions should not be accessible from outside the backend. The client does not and should not use them as the user actions encapsulate them for the client.

Also, the payload of meeting_user.{create|update} should be reduced and cleaned up. I don't see any necessity to be able to set the various relations via these actions, especially not together with the action currently being public.

[reiterl]

Which relations should be excluded from the meeting_user create and update actions?
I think, we need a way to update them. So why excluding them?

[jsangmeister]

Which relations should be excluded from the meeting_user create and update actions? I think, we need a way to update them. So why excluding them?

Most are updated through the reverse relation. Here is a list of all places where the actions are used and which fields are sent (besides the required fields):

• meeting_user.create:

  • openslides-backend/openslides_backend/action/actions/meeting/create.py

    Line 199 in 6195994

    self.execute_other_action(MeetingUserCreate, action_data)

    group_ids

  • openslides-backend/openslides_backend/action/actions/meeting/create.py

    Line 212 in 6195994

    self.execute_other_action(MeetingUserCreate, action_data)

    group_ids

  • openslides-backend/openslides_backend/action/actions/meeting_user/helper_mixin.py

    Line 16 in 6195994

    MeetingUserCreate,

    none

  • openslides-backend/openslides_backend/action/actions/motion/create_forwarded.py

    Line 100 in 6195994

    MeetingUserCreate,

    group_ids

  • openslides-backend/openslides_backend/action/actions/motion/create_forwarded.py

    Line 136 in 6195994

    MeetingUserCreate,

    group_ids

  • openslides-backend/openslides_backend/action/actions/personal_note/create.py

    Line 62 in 6195994

    MeetingUserCreate,

    personal_note_ids
• meeting_user.update:

  • openslides-backend/openslides_backend/action/actions/motion/create_forwarded.py

    Line 111 in 6195994

    MeetingUserUpdate,

    group_ids

  • openslides-backend/openslides_backend/action/actions/personal_note/create.py

    Line 48 in 6195994

    MeetingUserUpdate,

    personal_note_ids

  • openslides-backend/openslides_backend/action/actions/user/assign_meetings.py

    Line 101 in 6195994

    MeetingUserUpdate,

    group_ids

  • openslides-backend/openslides_backend/action/actions/user/assign_meetings.py

    Line 123 in 6195994

    MeetingUserUpdate,

    group_ids

So, the only fields actually used are group_ids and personal_note_ids, so the rest of the standard_fields can be removed without any consequence. I would keep group_ids since it is useful in multiple places and rewrite the places using personal_note_ids to instead update the reverse relation so personal_note_ids can be removed from the payloads as well.

Also, the meeting_user.delete action should be internal as well.